Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force thumbtable refresh when creating HDR #4932

Merged
merged 2 commits into from May 7, 2020
Merged

force thumbtable refresh when creating HDR #4932

merged 2 commits into from May 7, 2020

Conversation

Mark-64
Copy link
Contributor

@Mark-64 Mark-64 commented May 7, 2020

Fix for #4929, similar to #4904

@Mark-64
Copy link
Contributor Author

Mark-64 commented May 7, 2020

Travis CI failed, reason being the use of an uninitialized variable in case HDR creation is aborted.
This is easy to fix, however in that case DT also segfaults, even without this PR.
I will have to investigate more

@Mark-64 Mark-64 marked this pull request as draft May 7, 2020 08:04
@Mark-64 Mark-64 marked this pull request as ready for review May 7, 2020 08:38
@Mark-64
Copy link
Contributor Author

Mark-64 commented May 7, 2020

The segfault is a more general issue, not related to this part of the code, I will open a specific bug report

@Mark-64
Copy link
Contributor Author

Mark-64 commented May 7, 2020 •
edited

By the way, I could not replicate the segfault. It happens when you launch whatever job queue, for example exporting several images and then you click twice on the progress bar abort "X".
It happens with the master branch, but only with the Debug build, never with the Release build.
Maybe just a timing issue related to the slower Debug code, so not a real problem and in any case nothing related to this PR

@TurboGit TurboGit self-requested a review May 7, 2020 17:07
@TurboGit TurboGit added the bugfix pull request fixing a bug label May 7, 2020
@TurboGit TurboGit added this to the 3.2 milestone May 7, 2020
@TurboGit
Copy link
Member

TurboGit commented May 7, 2020

Looks good to me. Thanks!

@TurboGit TurboGit merged commit b26f247 into darktable-org:master May 7, 2020
@ptilopteri ptilopteri mentioned this pull request May 7, 2020
Closed
@Mark-64 Mark-64 deleted the force_thumbtable_refresh_HDR branch May 26, 2020 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboGit TurboGit Awaiting requested review from TurboGit

Assignees
No one assigned
Labels
bugfix pull request fixing a bug
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mark-64 @TurboGit