Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorbalancergb: rework the mask method #8620

Closed

Conversation

aurelienpierre
Copy link
Member

  1. Add a graph to show the mask opacities (y axis : 100% = fully opaque, 0% = fully transparent) for the generated shadows/midtones/highlights masks, as a function of luminance (x axis) :
    Screenshot_20210405_212801
  2. Add image previews for the mask areas (example : shadows vs. highlights), showing the output of the module :
    Screenshot_20210405_214613Screenshot_20210405_214527
  3. Add a middle-grey fulcrum parameter to slide the middle-grey reference (where both shadows and highlights masks have each a 50% opacity)
  4. Rework the midtones masking for better separation and transitions.
  5. Re-order and rename GUI controls for better understanding and accurate color-science references.

Example work produced with this new method :
image

@aurelienpierre aurelienpierre added the feature: enhancement current features to improve label Apr 5, 2021
@aurelienpierre aurelienpierre added this to the 3.6 milestone Apr 5, 2021
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested yet, some comments.

src/iop/colorbalancergb.c Show resolved Hide resolved
src/iop/colorbalancergb.c Show resolved Hide resolved
@aurelienpierre
Copy link
Member Author

@TurboGit using for_four_channels here doesn't work since the whole loop is SIMD (see CI failing).

@TurboGit
Copy link
Member

TurboGit commented Apr 7, 2021

@TurboGit using for_four_channels here doesn't work since the whole loop is SIMD (see CI failing).

Sorry, I didn't see that from the diff :( Will test soon.

src/iop/colorbalancergb.c Outdated Show resolved Hide resolved
@elstoc
Copy link
Contributor

elstoc commented Apr 8, 2021

This is the one thing I never understood with the olde worlde color balance - where the shadows/mid-tones/highlights fell - nice to be able to see/adjust it now.

@aurelienpierre
Copy link
Member Author

This is the one thing I never understood with the olde worlde color balance - where the shadows/mid-tones/highlights fell - nice to be able to see/adjust it now.

Don't get the wrong idea : the old color balance does not have explicit luminance masking, so it's simply not possible to present the splitting like that because there is no splitting at all. Old color balance does out = ((in + offset) * slope)^power, and that's it. Each parameter has more weight on some part of the range, but they are all applied on the whole range.

@TurboGit
Copy link
Member

TurboGit commented Apr 8, 2021

Manually merged. Thanks.

@TurboGit TurboGit closed this Apr 8, 2021
@elstoc elstoc added the documentation-pending a documentation work is required label Apr 8, 2021
@elstoc elstoc added documentation-complete needed documentation is merged in dtdocs and removed documentation-pending a documentation work is required labels May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-complete needed documentation is merged in dtdocs feature: enhancement current features to improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants