filmicrgb: add rational function to toe/shoulder #8764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rational polynomial designed by MrTeatime (https://discuss.pixls.us/t/proposal-for-updated-filmic-curve-parameterisation-in-darktable/23774/101) This is guaranteed to not over/under-shoot but the contrast is a bit muted near black/white. It is introduced in addition to soft/hard contrast intents as a "safe" method.
aurelienpierre
added
feature: enhancement
TurboGit
reviewed
Apr 24, 2021
| @@ -173,7 +175,7 @@ typedef struct dt_iop_filmicrgb_params_t | |||
| float black_point_target; // $MIN: 0.000 $MAX: 20.000 $DEFAULT: 0.01517634 $DESCRIPTION: "target black luminance" | |||
| float white_point_target; // $MIN: 0 $MAX: 1600 $DEFAULT: 100 $DESCRIPTION: "target white luminance" | |||
| float output_power; // $MIN: 1 $MAX: 10 $DEFAULT: 4.0 $DESCRIPTION: "hardness" | |||
| float latitude; // $MIN: 0.01 $MAX: 100 $DEFAULT: 25.0 | |||
| float latitude; // $MIN: 0.01 $MAX: 100 $DEFAULT: 33.0 | |||
There was a problem hiding this comment.
you've changed the default latitude unconditionally, is that intentional ? is that needed for the new safe mode ? if not maybe should be part of another PR, at least I'm not sure it is good to change that default as people are now used to the module... or maybe there is a strong point doing that ?
There was a problem hiding this comment.
As the name suggests, "safe" is safer as a default because users can blindly push contrast all the way, it will never overshoot. But safe is less contrasty so a bit more latitude is good.
There was a problem hiding this comment.
I missed that the default was also moved to safe mode.
elstoc
added
documentation-complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rational polynomial designed by MrTeatime (https://discuss.pixls.us/t/proposal-for-updated-filmic-curve-parameterisation-in-darktable/23774/101)
This is guaranteed to not over/under-shoot but the contrast is a bit muted near black/white.
It is introduced in addition to soft/hard contrast intents as a "safe" method.