Color calibration: disable Yxy <-> XYZ roundtrip if no gamut compression is requested #9257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfbrown
reviewed
Jun 16, 2021
TurboGit
added
the
priority: high
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion to Yxy will produce division by zero and all sorts of oddities if colors are out of gamut, even when no clipping and no gamut compression are required. In that case, we entirely remove the roundtrip, leaving only the channel mixing.
Notice it will fix the black pixels but will still result in RGB clipping at some point, meaning wrong colors anyway.
fix #9076