Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DngDecoder: improve ColorMatrix extraction #380

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Sep 6, 2022

See https://discuss.pixls.us/t/dng-hdr-created-in-dt-has-unsupported-input-profile/32528

Not really implementing "rationals support" throughout (I'll bring the comment back in), but should be an ok workaround (better than returning a zero matrix).

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Base: 60.23% // Head: 60.23% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6d7ce20) compared to base (c18d01b).
Patch coverage: 69.56% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #380   +/-   ##
========================================
  Coverage    60.23%   60.23%           
========================================
  Files          206      206           
  Lines        12526    12535    +9     
  Branches      1749     1752    +3     
========================================
+ Hits          7545     7551    +6     
- Misses        4842     4845    +3     
  Partials       139      139           
Flag Coverage Δ
integration 48.00% <76.19%> (+0.01%) ⬆️
rpu_u 48.00% <76.19%> (+0.01%) ⬆️
unittests 22.00% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/librawspeed/decoders/DngDecoder.cpp 51.53% <69.56%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kmilos kmilos changed the title Handle generic ColorMatrix denominators in DNGs DngDecoder: improve ColorMatrix extraction Sep 8, 2022
@kmilos kmilos force-pushed the patch-3 branch 3 times, most recently from 516bb62 to 8a912c8 Compare September 8, 2022 10:33
@LebedevRI LebedevRI merged commit edec592 into darktable-org:develop Oct 27, 2022
@LebedevRI
Copy link
Member

Thank you!

@kmilos kmilos deleted the patch-3 branch October 28, 2022 05:50
@kmilos
Copy link
Contributor Author

kmilos commented Oct 28, 2022

Thanks for merging and extending.

I guess this is now no longer compatible w/ https://github.com/darktable-org/darktable/blob/5a1a1845fa32378daa9db4b5c3a5705051b1ac49/src/common/imageio_rawspeed.cc#L268 as the division will have already been done when the float cast is requested?

@LebedevRI
Copy link
Member

Right, it is expected that places like that will have to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants