Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make new darkwallets use new format.
- Loading branch information
Showing
2 changed files
with
13 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93cda01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how this has any affect on the wallet format used,
fetch_stealth2
is just a copy offetch_stealth
?93cda01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is intended to affect thoroughly, e.g. libbitcoin, python-obelisk, gateway.js, sx / bx? Here I see stealth.js and gateway.js
93cda01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetch_stealth2 returns a different format (it's a different function on the gateway)
this is because of small changes on the stealth spec... fetch_stealth and fetch_stealth2 are part of a backwards compatibility scheme, so both formats can be queried by old and newer wallets. fetch_stealth will get proxied to older obelisk, fetch_stealth2 is querying the new libbitcoin-server that supports a different stealth scheme (different filtering of data contents).
93cda01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for explaining, now I see the server-side proxy change here. Cheers.