Update row impacts when a pocket is deleted.

darkwallet · Jan 22, 2015 · d38be46 · d38be46
1 parent 52a8204
commit d38be46
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/js/model/pocket/base.js b/src/js/model/pocket/base.js
@@ -121,6 +121,16 @@ BasePocket.prototype.destroy = function() {
     // Now delete our index in the wallet
     var pocketId = this.getPocketId();
     delete wallet.pockets.pockets[this.type][pocketId];
+
+    // Cleanup impact
+    wallet.identity.history.history.forEach(function(historyRow) {
+        var impact = historyRow.impact;
+        if (impact && impact.hasOwnProperty(pocketId) && impact[pocketId].type === self.type) {
+            delete impact[pocketId];
+        }
+    });
+
+    // Save
     wallet.store.save();
     return removed;
 };

diff --git a/test/unit/model/walletSpec.js b/test/unit/model/walletSpec.js
@@ -97,6 +97,9 @@ define(['model/wallet', 'bitcoinjs-lib'], function(Wallet, Bitcoin) {
           },
           save: function() {
           }
+        },
+        history: {
+          history: []
         }
       };
       wallet = new Wallet(identity.store, identity);