Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code reading directly from png #100

Open
leafcutterant opened this issue May 9, 2014 · 3 comments
Open

QR code reading directly from png #100

leafcutterant opened this issue May 9, 2014 · 3 comments

Comments

@leafcutterant
Copy link

Update: The purpose of this issue has changed. Look at this comment.

Old

Thank you for the new QR code system, it's much better!
However, on Windows I still can't read them. The two main options I found as of reader software is CodeTwo QR Code Reader and QuickMark, and neither reads them (while they mostly succeed with other QR codes). Onlinebarcodereader.com and zxing.org now both can read but that's relying on an online party.

Dark Wallet can already scan QR codes from webcam. How about an option to drag&drop QR code images into the Scan dialogue and decode them? Doing it locally would be cool.

Also, I agree with the notion to include the "bitcoin:" prefix.

@tilthz
Copy link
Contributor

tilthz commented May 9, 2014

Hi,

The main use of QR codes in dark wallet, like in any other bitcoin wallets, is camera-based address transfer to/from wallets in other devices or pieces of paper. It's hard for me to imagine the use case for someone to be scanning their own screen from within the same device, the logical thing to do would be copy/paste. Apart from that, none of the apps you mentioned are open source, so it's not easy for us to know if the issue is our fault or theirs. You can run any ZXing implementation locally. Check https://github.com/zxing/zxing

@leafcutterant
Copy link
Author

Consider the following: There is a website I want to donate to and all they offer is a QR code. To do this I either have to use an additional program or a decoder website. Dragging the image into DW is convenient and safer. I just thought reading QR from an image is not substantially harder than from webcam.

Of course this is a wishlist item and won't take it personally if you decide it's not worth the effort and close it.

(Disclosure: I can't code, if I could, I would make my own offline ZXing implementation and shut up.)

@sembrestels
Copy link
Member

Regarding QR showing, current QRs can be read by Electrum, Mycelium, Schildbach and I suppose any other mobile wallet (report if it is not the case). We are satisfied with that. We won't fix it for CodeTwo QR Code Reader and QuickMark. You can use instead QReader beta chrome extension, it is working properly with DarkWallet QRs.

Regarding your last comment about QR scanning, it is a proper feature request, so let's add it in the wishlist. We could inspire in QReader extension to do it.

I agree with you we should add the bitcoin: schema to the addresses when we generate the QR.

@caedesvvv caedesvvv changed the title QR code reading, round 2 QR code reading directly from png May 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants