Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create About Us.md #12

Merged
merged 2 commits into from
May 5, 2018
Merged

Conversation

princekelly1
Copy link
Contributor

Hi
this is a brief document describing the application to users, which users would find helpful.

About Us.md Outdated

This identifies the software component that generated the message, which is being used to filter messages.

### 3 The actual message
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header level inconsistency

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very wonderful work too،😐⁦✔️⁩⁦✔️⁩⁦➕✔️⁩⁦✔️⁩

Copy link
Owner

@darshanparajuli darshanparajuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't have spaces in the file name.

@princekelly1
Copy link
Contributor Author

I would make the requested changes now

Copy link
Contributor Author

@princekelly1 princekelly1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have made the requested changes

@princekelly1
Copy link
Contributor Author

all done

@princekelly1
Copy link
Contributor Author

princekelly1 commented May 3, 2018 via email

AboutUs.md Outdated
@@ -1,4 +1,4 @@
ABOUT US (LOGCAT READER)
ABOUT US (LOGCATREADER)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logcat Reader should have a space in the name.

@darshanparajuli
Copy link
Owner

Sorry for a late review, I've been busy with school lately.

@darshanparajuli darshanparajuli merged commit 4ef1ce1 into darshanparajuli:master May 5, 2018
@princekelly1
Copy link
Contributor Author

princekelly1 commented May 5, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants