Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

perf(ddcd): optimize DirtyCheckingChangeDetector.collectChanges() #693

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

vicb commented Mar 7, 2014

Adding a "fake head" allows saving some tests.

I should have some more changes from my cd work but I need to rebase them.

@vicb vicb added cla: yes and removed cla: no labels Mar 7, 2014

Contributor

caitp commented Mar 7, 2014

@vicb do you think you could post issues re: these also in angular/watchtower.js? I think this particular fix would probably apply there too, although it might be only a very marginal improvement (makes code a bit easier to read, so that's always an improvement)

mhevery added a commit to mhevery/angular.dart that referenced this pull request Mar 7, 2014

@vicb vicb closed this in 4453e3e Mar 7, 2014

Contributor

vicb commented Mar 8, 2014

@caitp I'll take a look and submit and issue/PR

@vicb vicb deleted the vicb:optim-cd branch Mar 8, 2014

@vicb vicb referenced this pull request in angular/watchtower.js Mar 8, 2014

Closed

Port some optimization from angular.dart #5

vicb added a commit to vicb/watchtower.js that referenced this pull request Mar 10, 2014

@vicb vicb referenced this pull request in angular/watchtower.js Mar 10, 2014

Closed

perf(ddcd): optimize DirtyCheckingChangeDetector.collectChanges() #7

caitp added a commit to angular/watchtower.js that referenced this pull request Mar 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment