This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
perf(ddcd): optimize DirtyCheckingChangeDetector.collectChanges() #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vicb do you think you could post issues re: these also in angular/watchtower.js? I think this particular fix would probably apply there too, although it might be only a very marginal improvement (makes code a bit easier to read, so that's always an improvement) |
mhevery
pushed a commit
to mhevery/angular.dart
that referenced
this pull request
Mar 7, 2014
|
@caitp I'll take a look and submit and issue/PR |
vicb
added a commit
to vicb/watchtower.js
that referenced
this pull request
Mar 10, 2014
caitp
pushed a commit
to angular/watchtower.js
that referenced
this pull request
Mar 10, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a "fake head" allows saving some tests.
I should have some more changes from my cd work but I need to rebase them.