add preserveHeaderCase argument #65
Conversation
|
Hi Nate, |
| } else { | ||
| name = name.toLowerCase(); | ||
| _originalHeaderName[name] = name; | ||
| } | ||
| _headers.remove(name); |
There was a problem hiding this comment.
We'd want the lowercase name here even if preserveHeaderCase is true.
There was a problem hiding this comment.
Actually I'm not confident with this behavior change.
Is this the behavior this package wants? If not, I just need to update the signature. Or I can do that whenever there is a request.
What do you think?
| # 0.10.0 | ||
|
|
||
| * Preparation for [HttpHeaders change]. Update signature of `set()` to match | ||
| new signature of `HttpHeaders`. The parameter is not yet forwarded and |
There was a problem hiding this comment.
This description doesn't make sense here. We are changing behavior based on this.
|
Ah, I didn't realize this was a test utility only... |
|
To shorten the cycle time, let's run with #66 We don't need anything more complex than that since it's a test utility so we only care about the signature, not the behavior of passing |
|
Sounds good. Thanks for the review. |
An upcoming SDK release will add a named argument which must be included for any class which
implementsthe interface. Pre-emptively add the argument to the signature so that we have a version of this package which is forward compatible with the SDK. We will properly forward the argument once we have an SDK release with the change.dart-lang/sdk#39657