Add an option to filter warnings about compling to JS #46
Conversation
Some Dart projects won't be compiled to JavaScript, which means these warnings are just spam. For example, projects that depend on dart:sky won't be compiled to JavaScript because dart:sky cannot be compiled to JavaScript.
|
@devoncarew I'm starting to feel like we need a |
| @@ -153,9 +153,15 @@ class AtomDartPackage extends AtomPackage { | |||
| 'type': 'boolean', | |||
| 'default': false | |||
| }, | |||
| 'showUnnamedLibraryWarning': { | |||
| 'filterUnnamedLibraryWarnings': { | |||
There was a problem hiding this comment.
While slightly inaccurate, this setting was named showUnnamed... in order for it to display after the other settings in the preferences page. They're sorted (I believe) by pref id. filter will sort before everything else, and these aren't the primary prefs for the app.
We can play with some id prefixes in order to group settings; let's keep it as you have for now.
|
@abarth, lgtm! What's an example of a @radicaled, yup, agreed. We're making these settings global, when a user might really want some on for certain projects and off for others. The setting that @abarth contributed will be something that you'd likely want on for that project for any developer of it, which does feel like a setting you'd commit to the project repo. @bwilkerson @pq have talked about a project level analysis settings file, which the analyzer and analysis server would use for things like configuring lints. That sounds similar to what we'd want. Not sure what the timeframe for that is, or if the intention is for it to also be able to configure spec warnings. And re: the existing filter - for unnamed library warnings - the latest on that is that the spec will change to remove the warning. So that particular filter is short-lived. |
The one I'm hitting is "When compiled to JS, this test might return true when the left hand side is an int". |
Add an option to filter warnings about compling to JS
Shouldn't be too far off. It occurs to me though that we should track this with an issue... Could you open one and assign it me? Thanks! |
Some Dart projects won't be compiled to JavaScript, which means these warnings
are just spam. For example, projects that depend on dart:sky won't be compiled
to JavaScript because dart:sky cannot be compiled to JavaScript.
Example warning: "When compiled to JS, this test might return true when the left hand side is an int"