Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka 0.10 #13

Open
wants to merge 73 commits into
base: master
Choose a base branch
from
Open

Kafka 0.10 #13

wants to merge 73 commits into from

Conversation

pulyaevskiy
Copy link
Collaborator

@pulyaevskiy pulyaevskiy commented Mar 4, 2017

Pull request to track progress of refactoring to 0.10 protocol.
Everything below is a minimum required to get to the first public alpha.

Core:

  • Refactor and cleanup binary protocol layer
  • Add request timeout to Session
  • Complete implementation of all APIs for 0.10 protocol version
    • MessageSet and Message (v1)
    • TopicMetadata
    • Produce (v2)
    • Fetch (v2)
    • ListOffset (v1)
    • GroupCoordinator
    • OffsetCommit (v2)
    • OffsetFetch (v1)
    • JoinGroup (v1)
    • SyncGroup
    • Heartbeat
    • LeaveGroup
    • ListGroups
    • DescribeGroups
    • ApiVersions
    • CreateTopics
    • DeleteTopics
  • Introduce basic serialization interface
  • Dynamic api version resolution
  • Testing facilities

Producer:

  • Minimum implementation
  • Batch sends
  • Expose minimum configuration options
  • Handle maxRequestSize and split requests
  • Control in-flight requests per connection
  • GZip

Consumer:

  • Minimum implementation
  • Make Consumer a StreamIterator
  • Heartbeats
  • Expose configuration options
  • Handle broker rebalance and migration of partitions within Kafka cluster
  • GZip

General:

  • Cleanup public interface and exports.
  • Resolve all critical TODOs left in the code.
  • Update Travis build
  • Update documentation

Todo:

  • Add more bullet points above

@pulyaevskiy pulyaevskiy self-assigned this Mar 4, 2017
@codecov
Copy link

codecov bot commented Mar 19, 2017

Codecov Report

Merging #13 into master will decrease coverage by 9.55%.
The diff coverage is 79.44%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   88.59%   79.03%   -9.56%     
==========================================
  Files          22       27       +5     
  Lines         973     1269     +296     
==========================================
+ Hits          862     1003     +141     
- Misses        111      266     +155
Impacted Files Coverage Δ
lib/src/util/crc32.dart 100% <ø> (ø) ⬆️
lib/src/versions.dart 100% <100%> (ø)
lib/src/session.dart 100% <100%> (+10.09%) ⬆️
lib/src/util/group_by.dart 100% <100%> (ø)
lib/src/errors.dart 24.54% <24.54%> (ø)
lib/src/util/tuple.dart 40% <40%> (ø)
lib/src/serialization.dart 50% <50%> (ø)
lib/src/consumer_group.dart 50% <53.33%> (-37.72%) ⬇️
lib/src/messages.dart 63.63% <63.63%> (ø)
lib/src/consumer.dart 67.46% <69.67%> (-10%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1baed1...850772d. Read the comment docs.

larryaasen and others added 23 commits April 9, 2020 08:36
* Updated code to support Dart 2.7, updated package dependency versions, and removed a few unused imports.

* Updated travis config.

* Fixed code that broke the tests.

* Removed Dart 1.x new keywords from examples.
Updated code in kafka-0.10 branch to support Dart 2.7 (#14)
* Updated code to support Dart 2.7, updated package dependency versions, and removed a few unused imports.

* Updated travis config.

* Fixed code that broke the tests.

* Removed Dart 1.x new keywords from examples.

* Updated docker image ches/kafka to latest. Updated docker image jplock/zookeeper to latest.

* Updated to the latest Docker Official Image of zookeeper, 3.6.0.

* Disabled the uploading to codecov.io from Travis job to ensure test success until it is more stable.

* Removed the remaining code coverage steps in Travis build until it gets more stable.
…ng used instead of '=', so the _subscription was not reset to null on rebalance. Also, renamed async.dart to consumer_streamiterator.dart which was more appropriate.
Updated Docker images to the latest (#15)
… kafka-0.10

* 'kafka-0.10' of https://github.com/larryaasen/kafka:
  Updated Docker images to the latest (#15)
… to larryaasen/kafka, which is Kafka 2.5.0. The image larryaasen/kafka is a fork of ches/kafka that was updated to the latest version of Kafka. Added missing Kafka config offsets.topic.replication.factor=1 which was new in Kafka 0.11.0.
Fixed bug in ConsumerStreamIterator.attachStream()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants