Implement CancelableOperation.then #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue of whether to propagate the cancellation to the original operation still happens here, but I think this is a lot clearer with what is happening than the version with callbacks returning CancelableOperations. |
TastyPi
force-pushed
the
cancelable-operation-then
branch
from
65a542c
to
72bb130
Compare
TastyPi
force-pushed
the
cancelable-operation-then
branch
from
72bb130
to
53acec3
Compare
|
LGTM. It's a much more focused API than the original one. A cancelable operation is a combination of result future and cancel channel. It makes sense to have an operation which acts on both (a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #80.