Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--output shouldn't output old optional assets that were not needed by the last build #1033

Closed
jakemac53 opened this issue Feb 20, 2018 · 2 comments
Closed

--output shouldn't output old optional assets that were not needed by the last build #1033

jakemac53 opened this issue Feb 20, 2018 · 2 comments
Labels
package:build_runner type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Milestone
M2: Ready for Dar...

Comments

@jakemac53
Copy link
Contributor

Today, if you build with dartdevc, and then do a dart2js build, you actually end up with the dartdevc modules output to the merged directory. Everything still works, but there are a lot of turds in the output as a result.

I think to resolve this we can skip optional assets initially when iterating the graph, but then make sure to include all optional inputs of required outputs.
@jakemac53 jakemac53 added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) package:build_runner labels Feb 20, 2018
This was referenced Feb 20, 2018
Merged
Closed
@natebosch natebosch added this to the M1: Replace `pub build` milestone Feb 26, 2018
@jakemac53
Copy link
Contributor Author

Re-opening because the serve portion of this hasn't been implemented

@jakemac53 jakemac53 reopened this Feb 27, 2018
@natebosch natebosch mentioned this issue Apr 3, 2018
Closed
@kevmoo
Copy link
Member

kevmoo commented Apr 11, 2018

Re-opening because the serve portion of this hasn't been implemented

Just hit this w/ webdev tests.

@natebosch natebosch mentioned this issue May 1, 2018
Merged
natebosch added a commit that referenced this issue May 3, 2018
@natebosch
Don't serve optional assets unused in the build
8d5ed08 
Closes #1033

Use the `OptionalOutputTracker` in `FinalizedAssetReader` so the asset
handler sees these files as if they were not output.
natebosch added a commit that referenced this issue May 3, 2018
@natebosch
Don't serve optional assets unused in the build
be5c88a 
Closes #1033

Use the `OptionalOutputTracker` in `FinalizedAssetReader` so the asset
handler sees these files as if they were not output.
@natebosch natebosch mentioned this issue May 3, 2018
Merged
natebosch added a commit that referenced this issue May 4, 2018
@natebosch
Don't serve optional assets unused in the build (#1412)
2a20d62 
Closes #1033

Use the `OptionalOutputTracker` in `FinalizedAssetReader` so the asset
handler sees these files as if they were not output.

Use unreadableReason from canRead so we're sure they are consistent.

Add a reset method to `OptionalOutputTracker` so it can be used across builds.
kevmoo added a commit to dart-lang/webdev that referenced this issue May 22, 2018
@kevmoo
Remove work-around for fixed build_runner issue
8ecc079 
dart-lang/build#1033 was fixed in
build_runner v0.8.9
@kevmoo kevmoo mentioned this issue May 22, 2018
Merged
kevmoo added a commit to dart-lang/webdev that referenced this issue May 22, 2018
@kevmoo
Remove work-around for fixed build_runner issue (#56)
f8cee12 
dart-lang/build#1033 was fixed in
build_runner v0.8.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:build_runner type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
M2: Ready for Dart4Web Beta
Development

No branches or pull requests
3 participants
@kevmoo @jakemac53 @natebosch