-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failures when Dart updates #2075
Comments
From @alexander-doroshko on March 5, 2019 8:46 @vsmenon, I'm not sure |
From @drpond1 on March 5, 2019 20:38 I believe this was addressed in a recent related issue. The problem is build_runner: ^0.10.0 My situation is that I may keep an older app running, because I want to copy "user" data from the old/flawed app into the new one. New builds may fail if there is a Dart update between the time the older app was started and the new build was attempted. (There cannot be another running app.) Because of the build failure, new code executes with a missing file error. The failure is intended by the Dart design and the shown pub spec is still recommended so the issue was closed. The residual problem is that the failures I encountered are unexpected and recognition of how to recover was not immediately obvious to me. If this analysis of the problem is correct, the simplest fix is a small change in documentation. However, my situation might be sufficiently rare that no change should be made. On Tue, Mar 5, 2019 at 3:46 AM Alexander Doroshko notifications@github.com
|
Ahh, my mistake triaging. I'll move. |
This is very unclear to me - what action did you take that triggered the error? My initial assumption was that the action was updating the Dart sdk, which triggered a build failure - but that wouldn't make sense if updating the SDK is part of the solution steps...
The only time you should need to update the SDK is if you are using new features only found in the new SDK. If your code, and the versions of dependencies you're using, worked with the old SDK they should continue to work. Upgrading the SDK within major versions also should not trigger build failures except in remote edge cases. Upgrading from Dart 1.x to Dart 2.x is expected to cause failures which require changes in your code.
This leads me to think the issue is instead that you updated some packages and things failed until the SDK was updated? This is expected only if the package maintainers are doing something wrong - for example if they use a new feature from Dart 2.2 but do not indicate the requirement in their pubspec (an unfortunately common mistake, even the Dart team does this from time to time).
Without a specific error it's very unlikely we'll be able to investigate. I'm afraid this issue is not actionable for us. If you can give us a specific reproduction case where updating the Dart SDK within a major version (for example 2.0 to 2.1) causes the build to fail we can investigate. Otherwise if you can give a specific reproduction case where updating a dependency required an update to your locally installed SDK we can help you track down the mistake that was made. |
I cannot tell if you looked at the updated comment or not. vsmenon posted
it so that it
appears in the middle of the thread.
If begins:
"I believe this was addressed in a recent related issue. The problem is"
****
Short version:
My situation is that I may keep an older app running, because I want to
copy "user" data from the old/flawed app into the new one. New builds may
fail if there is an update to the Dart build packages between the time the
older app was started and the new build was attempted Because of the
build failure, new code executes with a missing file error.
****
This is how the build procedure is supposed to work.
It would be useful to simply be able to fix a small problem without
having to set things back up, but now that I understand the problem I can
deal with it. I suggested an update in the documentation OR that the
issue just be closed.
…On Tue, Mar 5, 2019 at 6:21 PM Nate Bosch ***@***.***> wrote:
Closed #2075 <#2075>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2075 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AkTyUyF9KAgdjFDfaeVLFCmVQ7AL9N6Uks5vTvwQgaJpZM4bfgts>
.
|
From @drpond1 on November 17, 2018 14:19
When a new version of dart appears eventually my code will not run -- some kind of script error on startup, before it gets to my code. (Unfortunately, I did not save the error.)
This is resolved by updating the dartsdk, getting/updating dependencies and rebuilding.
It seems to me I should still be able to run with the old system. If not, there should at least be a message that a dartsdk update is required.
This is the second time this has happened in the last few months.
I use IntelliJ Community Edition.
Copied from original issue: dart-lang/sdk#35203
The text was updated successfully, but these errors were encountered: