Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/remove experiment warnings #2787

Closed
jakemac53 opened this issue Aug 13, 2020 · 2 comments · Fixed by #2840
Closed

Update/remove experiment warnings #2787

jakemac53 opened this issue Aug 13, 2020 · 2 comments · Fixed by #2840
Assignees
@jakemac53
Labels
package:build_resolvers

Comments

@jakemac53
Copy link
Contributor

See the meta issue dart-lang/sdk#43031

Given that experiments no longer require the latest language version, and that the analyzer is changing to detect the "current version" from the actual sdk it is provided, we can remove the warnings about trying to use an experiment when the analyzer has a newer language version than the current sdk here .
@jakemac53 jakemac53 self-assigned this Aug 13, 2020
@jakemac53 jakemac53 mentioned this issue Aug 13, 2020
Closed
7 tasks
@leafpetersen
Copy link
Member

Is this a blocker for completion of the feature or just a nice to have? Where are we with this?

@jakemac53
Copy link
Contributor Author

This is just a nice to have, not a blocker.

@jakemac53 jakemac53 mentioned this issue Sep 25, 2020
Merged
jakemac53 added a commit that referenced this issue Sep 25, 2020
@jakemac53
update language version check when using experiments (#2840)
90531a4 
We no longer require an exact match, only that the sdk version is not ahead of the analyzer version.

Also:

* Prepares to release build_resolvers 1.4.1
* Run all packages that have tests which require experiment flags on 2.10 dev instead of 2.11 dev since analyzer doesn't yet have an analyzer version for 2.11.
* Closes #2787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakemac53 jakemac53

Labels
package:build_resolvers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update language version check when using experiments dart-lang/build
2 participants
@jakemac53 @leafpetersen