Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update language version check when using experiments #2840

Merged
merged 4 commits into from Sep 25, 2020
Merged

update language version check when using experiments #2840

merged 4 commits into from Sep 25, 2020

Conversation

jakemac53
Copy link
Contributor

@jakemac53 jakemac53 commented Sep 25, 2020 •
edited

We no longer require an exact match, only that the sdk version is not ahead of the analyzer version.

Also:

  • Prepares to release build_resolvers 1.4.1
  • Run all packages that have tests which require experiment flags on 2.10 dev instead of 2.11 dev since analyzer doesn't yet have an analyzer version for 2.11.
  • Closes Update/remove experiment warnings #2787

@jakemac53
update language version check when using experiments
267b776 
- no longer requires an exact match, only that the sdk
  version is not ahead of the analyzer version.

Also skips failing tests due to outdated analyer version.
@googlebot googlebot added the cla: yes Google is happy with the PR contributors label Sep 25, 2020
@jakemac53
Copy link
Contributor Author

cc @scheglov

@jakemac53 jakemac53 mentioned this pull request Sep 25, 2020
Closed
@jakemac53
Copy link
Contributor Author

jakemac53 commented Sep 25, 2020 •
edited

Hmm, I am going to end up having to skip a lot of our integration testing here to make this work.... a lot of it relies on enabling nnbd currently.

@jakemac53
Copy link
Contributor Author

I think I am going to go with a different strategy instead of skipping tests I will just run most tests on the previous 2.10 dev release and not 2.11 which is basically unusable.

@jakemac53
Copy link
Contributor Author

aaand of course the flutter tests just clone master lol so they get the latest, ill have to skip those

@jakemac53 jakemac53 mentioned this pull request Sep 25, 2020
Closed
@jakemac53 jakemac53 merged commit 90531a4 into master Sep 25, 2020
@jakemac53 jakemac53 deleted the skip-resolver-tests branch September 25, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

Assignees
No one assigned
Labels
cla: yes Google is happy with the PR contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update/remove experiment warnings
3 participants
@jakemac53 @natebosch @googlebot