Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand capability of testBuilder #152

Merged
merged 2 commits into from
Dec 1, 2016
Merged

Conversation

natebosch
Copy link
Member

  • Add back onLog argument and dep on package:logging since there is a
    user of this feature in the old testPhases that needs to be migrated
  • Only do any checking of outputs when the outputs argument is
    non-null rather than expect empty outpus on null
  • Don't double up on the check against actual assets. This was a
    holdover from the version where we were checking both written assets
    and the results object
  • Add in an isInput callback as an alternative to generateFor since
    this is sometimes an easier way to express the constraints (ie when
    all assets in the root package are inputs)
  • Add back the writer argument to allow stubbing behavior or doing
    more complex validation. Take in an AssetWriter and spy on it rather
    than require an InMemoryAssetWriter
  • Add a method to make new assets available through the
    InMemoryAssetWriter rather than require they are first written through
    the writer and sharing the cache

- Add back onLog argument and dep on package:logging since there is a
  user of this feature in the old testPhases that needs to be migrated
- Only do any checking of outputs when the `outputs` argument is
  non-null rather than expect empty outpus on null
- Don't double up on the check against actual assets. This was a
  holdover from the version where we were checking both written assets
  and the `results` object
- Add in an `isInput` callback as an alternative to `generateFor` since
  this is sometimes an easier way to express the constraints (ie when
  all assets in the root package are inputs)
- Add back the `writer` argument to allow stubbing behavior or doing
  more complex validation. Take in an AssetWriter and spy on it rather
  than require an InMemoryAssetWriter
- Add a method to make new assets available through the
  InMemoryAssetWriter rather than require they are first written through
  the writer and sharing the cache
@googlebot googlebot added the cla: yes Google is happy with the PR contributors label Dec 1, 2016
Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@natebosch natebosch merged commit ab241c3 into master Dec 1, 2016
@natebosch natebosch deleted the natebosch_more-test-features branch December 1, 2016 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google is happy with the PR contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants