Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [co19] Roll co19 to b572e42fbbfe89644236601f93cb982f23f4d7f1 #1388

Closed
eernstg opened this issue Aug 9, 2022 · 3 comments
Closed

Failures on [co19] Roll co19 to b572e42fbbfe89644236601f93cb982f23f4d7f1 #1388

eernstg opened this issue Aug 9, 2022 · 3 comments
Labels
area-test

Comments

@eernstg
Copy link
Member

eernstg commented Aug 9, 2022

There are new test failures on [co19] Roll co19 to b572e42fbbfe89644236601f93cb982f23f4d7f1.

The tests

co19/Language/Statements/For/Asynchronous_For_in/execution_A01_t03 MissingCompileTimeError (expected Pass)
co19/Language/Statements/For/Asynchronous_For_in/execution_A02_t01 Timeout (expected Pass)
co19/Language/Statements/For/Asynchronous_For_in/execution_A02_t02 Timeout (expected Pass)
co19/Language/Statements/For/For_in/execution_t07 MissingCompileTimeError (expected Pass)
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t01 RuntimeError (expected Pass)
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t02 RuntimeError (expected Pass)
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t03 RuntimeError (expected Pass)
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t04 RuntimeError (expected Pass)
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t05 RuntimeError (expected Pass)
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t06 RuntimeError (expected Pass)
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t07 RuntimeError (expected Pass)
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t08 RuntimeError (expected Pass)
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A03_t01 RuntimeError (expected Pass)
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A03_t02 RuntimeError (expected Pass)
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A05_t02 RuntimeError (expected Pass)
co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_A03_t07 RuntimeError (expected Pass)
co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_A03_t08 RuntimeError (expected Pass)
co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_A03_t09 RuntimeError (expected Pass)
co19/LibTest/ffi/Long/Long_A01_t01 RuntimeError (expected Pass)
co19/LibTest/ffi/UnsignedLong/UnsignedLong_A01_t01 RuntimeError (expected Pass)
co19/LibTest/ffi/WChar/WChar_A01_t01 RuntimeError (expected Pass)

are failing on configurations

analyzer-asserts-linux
cfe-strong-linux
cfe-weak-linux
dart2js-hostasserts-strong-linux-x64-chrome
dart2js-hostasserts-weak-linux-x64-chrome
dartdevk-strong-linux-release-chrome
dartdevk-weak-linux-release-chrome
dartk-strong-linux-debug-x64
dartk-strong-linux-release-x64
dartk-weak-asserts-linux-debug-x64
dartk-weak-asserts-linux-release-x64
@eernstg
Copy link
Member Author

eernstg commented Aug 9, 2022

@sgrekhov, could you take a look and see if some of these failures could indicate problems with the tests? A few of these are clearly tool issues, but, for instance, I don't know enough about ffi to be able to see what's going on with the ffi tests.

@sgrekhov
Copy link
Contributor

sgrekhov commented Aug 9, 2022

Yes, sure. FFI failures do look like test issues

@athomas athomas transferred this issue from dart-lang/sdk Aug 9, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 9, 2022
@sgrekhov
dart-lang#1388. FFI test failures fixed
b5f570a
@sgrekhov
Copy link
Contributor

sgrekhov commented Aug 9, 2022

Failures triaged

Analyzer-asserts-linux cfe...  
new test -> MissingCompileTimeError (expected Pass)  
co19/Language/Statements/For/Asynchronous_For_in/execution_A01_t03 dart-lang/sdk#49495
co19/Language/Statements/For/For_in/execution_t07 dart-lang/sdk#49495
dart2js...dartdevk...  
new test -> RuntimeError (expected Pass)  
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t04 dart-lang/sdk#49623, dart-lang/sdk#49621
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t06 dart-lang/sdk#49623, dart-lang/sdk#49621
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t07 dart-lang/sdk#49623, dart-lang/sdk#49621
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A03_t01 dart-lang/sdk#49623, dart-lang/sdk#49621
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A03_t02 dart-lang/sdk#49623, dart-lang/sdk#49621
dartdevk...  
new test -> RuntimeError (expected Pass)  
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t01 dart-lang/sdk#49621
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t02 dart-lang/sdk#49621
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t03 dart-lang/sdk#49621
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t05 dart-lang/sdk#49621
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t08 dart-lang/sdk#49621
co19/Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A05_t02 dart-lang/sdk#49621
co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_A03_t07 dart-lang/sdk#49621
co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_A03_t08 dart-lang/sdk#49621
co19/Language/Statements/Yield_and_Yield_Each/Yield_Each/execution_async_A03_t09 dart-lang/sdk#49621
new test -> Timeout (expected Pass)  
co19/Language/Statements/For/Asynchronous_For_in/execution_A02_t01 dart-lang/sdk#49622
co19/Language/Statements/For/Asynchronous_For_in/execution_A02_t02 dart-lang/sdk#49622
dartk...  
new test -> RuntimeError (expected Pass)  
co19/LibTest/ffi/Long/Long_A01_t01 Fixed. #1389
co19/LibTest/ffi/UnsignedLong/UnsignedLong_A01_t01 Fixed. #1389
co19/LibTest/ffi/WChar/WChar_A01_t01 Fixed. #1389

eernstg pushed a commit that referenced this issue Aug 11, 2022
@sgrekhov
#1388. FFI test failures fixed (#1389)
e1a272c 
Authored by @sgrekhov.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 15, 2022
@sgrekhov
dart-lang#1388. FFI tests fixed for 32-bit systems
31ae8cd
eernstg pushed a commit that referenced this issue Aug 15, 2022
@sgrekhov
#1388. FFI tests fixed for 32-bit systems (#1392)
08c8887 
Authored by @sgrekhov.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 15, 2022
@sgrekhov
dart-lang#1388. FFI test failures fixed (dart-lang#1389)
4db862a 
Authored by @sgrekhov.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Sep 12, 2022
@sgrekhov @athomas
[co19] Roll co19 to 3c9ba02a1e4bfc416ff3cd05df512d63deacd885
272a108 
2022-09-02 sgrekhov22@gmail.com dart-lang/co19#1399. on clause tests added (dart-lang/co19#1416)
2022-09-02 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] Type annotations and record expressions tests updated (dart-lang/co19#1415)
2022-09-01 sgrekhov22@gmail.com Fixes dart-lang/co19#1398. Fix tests that use unreachable code after `Never` (dart-lang/co19#1402)
2022-08-31 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] Typos in subtyping tests description fixed (dart-lang/co19#1414)
2022-08-31 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] Subtyping tests for records added (dart-lang/co19#1412)
2022-08-31 asashour@yahoo.com Fix typo (dart-lang/co19#1413)
2022-08-30 sgrekhov22@gmail.com dart-lang/co19#1405. BytesBuilder tests moved from dart:io to dart:typed_data (dart-lang/co19#1410)
2022-08-30 sgrekhov22@gmail.com dart-lang/co19#1399. Tests for record types. Part 1 (dart-lang/co19#1395)
2022-08-24 sgrekhov22@gmail.com dart-lang/co19#1405. Don't use deprecated API in co19 tests. Update generated files (dart-lang/co19#1407)
2022-08-24 sgrekhov22@gmail.com dart-lang/co19#1405. Don't use deprecated API in co19 tests (dart-lang/co19#1406)
2022-08-23 sgrekhov22@gmail.com Fixes dart-lang/co19#1361. Private fields promotion tests added (dart-lang/co19#1391)
2022-08-23 sgrekhov22@gmail.com Fixes dart-lang/co19#1394. Add missing compile-error (dart-lang/co19#1396)
2022-08-23 sgrekhov22@gmail.com Fixes dart-lang/co19#1403. Added test that `super` cannot be used as an expression (dart-lang/co19#1404)
2022-08-15 sgrekhov22@gmail.com dart-lang/co19#1388. FFI tests fixed for 32-bit systems (dart-lang/co19#1392)
2022-08-11 sgrekhov22@gmail.com dart-lang/co19#1388. FFI test failures fixed (dart-lang/co19#1389)

Change-Id: I2eee6c193eed1ce8a511f3ef5667ded947fbfad8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257700
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sgrekhov @eernstg @mit-mit