Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Records] Co19 tests - add tests #1399

Closed
itsjustkevin opened this issue Aug 19, 2022 · 12 comments
Closed

[Records] Co19 tests - add tests #1399

itsjustkevin opened this issue Aug 19, 2022 · 12 comments
Assignees
@eernstg
Labels
type-enhancement A request for a change that isn't a bug

Comments

@itsjustkevin
Copy link

No description provided.

@sgrekhov sgrekhov added type-enhancement A request for a change that isn't a bug closed-duplicate Closed in favor of an existing report and removed type-enhancement A request for a change that isn't a bug labels Aug 22, 2022
@sgrekhov
Copy link
Contributor

Closing as a duplicate of #1393

@itsjustkevin
Copy link
Author

@sgrekhov can you add your issue to the project instead of closing it out as a duplicate? We would still like to track the work being done.

@sgrekhov sgrekhov added type-enhancement A request for a change that isn't a bug and removed closed-duplicate Closed in favor of an existing report labels Aug 24, 2022
@sgrekhov sgrekhov reopened this Aug 24, 2022
@sgrekhov
Copy link
Contributor

@itsjustkevin sorry. I'll go on the work using this issue and close the previous one

@sgrekhov sgrekhov mentioned this issue Aug 24, 2022
Closed
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 25, 2022
@sgrekhov
dart-lang#1399. [Records] Tests for members added
83f8480
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 30, 2022
@sgrekhov
dart-lang#1399. [Records] Subtyping tests for records added
60ef745
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 30, 2022
@sgrekhov
dart-lang#1399. [Records] Assertion text updated for members tests
e8b946b
eernstg pushed a commit that referenced this issue Aug 30, 2022
@sgrekhov
#1399. Tests for record types. Part 1 (#1395)
b5d2d5c 
Authored by @sgrekhov. Record tests added.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 31, 2022
@sgrekhov
dart-lang#1399. [Records] Record expressions tests updated according …
5b6211c 
…to the specification changes
eernstg pushed a commit that referenced this issue Aug 31, 2022
@sgrekhov
#1399. [Records] Subtyping tests for records added (#1412)
56d6df6 
Authored by @sgrekhov.

Subtyping tests for records added.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 31, 2022
@sgrekhov
dart-lang#1399. [Records] Typos in subtyping tests description fixed
195d13d
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Aug 31, 2022
@sgrekhov
dart-lang#1399. [Records] Typos in subtyping tests description fixed
d01c78a
eernstg pushed a commit that referenced this issue Aug 31, 2022
@sgrekhov
#1399. [Records] Typos in subtyping tests description fixed (#1414)
10f2a33 
Authored by @sgrekhov.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 1, 2022
@sgrekhov
dart-lang#1399. [Records] Subtyping tests for records added (dart-lan…
d26afe8 
…g#1412)

Authored by @sgrekhov.

Subtyping tests for records added.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 1, 2022
@sgrekhov
dart-lang#1399. [Records] Type annotations tests updated to the curre…
2495f53 
…nt spec
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 1, 2022
@sgrekhov
dart-lang#1399. [Records] Typos in subtyping tests description fixed (d…
d137ea1 
…art-lang#1414)

Authored by @sgrekhov.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 1, 2022
@sgrekhov
dart-lang#1399. [Records] Type annotations and record expressions tes…
080ae57 
…ts updated to the current spec
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 2, 2022
@sgrekhov
dart-lang#1399. on clause tests added
cab227c
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 2, 2022
@sgrekhov
dart-lang#1399. [Records] More type annotations and record expression…
6f77a88 
…s tests added
chloestefantsova pushed a commit that referenced this issue Sep 2, 2022
@sgrekhov
#1399. [Records] Type annotations and record expressions tests updated (
749e450 
#1415)

* #1399. [Records] Type annotations and record expressions tests updated to the current spec

* #1399. [Records] More type annotations and record expressions tests added
eernstg pushed a commit that referenced this issue Sep 2, 2022
@sgrekhov
#1399. on clause tests added (#1416)
3c9ba02 
Authored by @sgrekhov.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 5, 2022
@sgrekhov
dart-lang#1399. [Records] Update members and static semantics tests a…
8ccb1a8 
…ccording to the review notes
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Sep 6, 2022
@sgrekhov
dart-lang#1399. [Records] Add upper and lower bounds tests, type anno…
5942b0e 
…tations tests updated
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 12, 2022
@sgrekhov
dart-lang#1399. [Records] Interaction with legacy tests added
6ebd231
chloestefantsova pushed a commit that referenced this issue Oct 12, 2022
@sgrekhov
#1399. [Records] More members tests added (#1501)
7051c17
eernstg pushed a commit that referenced this issue Oct 19, 2022
@sgrekhov
#1399. [Records] Interaction with legacy tests added (#1502)
bd1d91e 
Authored by @sgrekhov.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 24, 2022
@sgrekhov @athomas
[co19] Roll co19 to 0c2b4c60350c7e3239913b8186770e5203c18eb2
cd75b47 
2022-10-21 sgrekhov22@gmail.com Fixes dart-lang/co19#1511. [Records] Remove `records` experimental flag from legacy libraries (dart-lang/co19#1512)
2022-10-21 sgrekhov22@gmail.com Fixes dart-lang/co19#1477. [Records] Type inference tests updated (dart-lang/co19#1500)
2022-10-21 sgrekhov22@gmail.com Fixes dart-lang/co19#1505. [Records] Added tests for dynamic access to record fields (dart-lang/co19#1507)
2022-10-19 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] Interaction with legacy tests added (dart-lang/co19#1502)
2022-10-19 sgrekhov22@gmail.com dart-lang/co19#195. Typos fixed (dart-lang/co19#1508)
2022-10-19 sgrekhov22@gmail.com dart-lang/co19#993. [ffi] nullptr test added (dart-lang/co19#1506)
2022-10-14 asashour@yahoo.com Fix typos (dart-lang/co19#1504)
2022-10-12 sgrekhov22@gmail.com Fixes dart-lang/co19#1427. Expando tests added (dart-lang/co19#1479)
2022-10-12 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] More members tests added (dart-lang/co19#1501)
2022-10-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.0.2 to 3.1.0 (dart-lang/co19#1499)
2022-10-11 sgrekhov22@gmail.com dart-lang/co19#1400. [Views] Syntax tests added (dart-lang/co19#1498)
2022-10-07 sgrekhov22@gmail.com Fixes dart-lang/co19#1491. Use correct record type in 'as' expression (dart-lang/co19#1497)
2022-10-07 sgrekhov22@gmail.com Fixes dart-lang/co19#1489. Don't use '?' in expressions (dart-lang/co19#1495)
2022-10-07 sgrekhov22@gmail.com Fixes dart-lang/co19#1488. Use correct record types (dart-lang/co19#1493)
2022-10-07 sgrekhov22@gmail.com Fixes dart-lang/co19#1490. Missing parameters names added (dart-lang/co19#1496)

Change-Id: I6d26701ee14a0c7820e3c3094d7d850c0f914028
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265087
Reviewed-by: Alexander Thomas <athom@google.com>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 24, 2022
@sgrekhov
dart-lang#1399. Object member names are not allowed for positional fi…
150c9f1 
…elds names
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 24, 2022
@sgrekhov
dart-lang#1399. Missed parameters names added
0c3a342
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 24, 2022
@sgrekhov
dart-lang#1399. [Records] Check corner case with trailing zeros for p…
d285f3a 
…ositional field getter
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 25, 2022
@sgrekhov
dart-lang#1399. [Records] Check a big record with big number of posit…
6ba8767 
…ional fields
eernstg pushed a commit that referenced this issue Oct 26, 2022
@sgrekhov
#1399. Object member names are not allowed for positional fields names (
642b786 
#1513)

Authored by @sgrekhov.

Adjusting record tests. Object member names are not allowed for positional fields names. Missing parameters names added, run-time types fixed.
@sgrekhov
Copy link
Contributor

Spec was changed (Ambiguity with metadata annotations added), need to update tests accordingly

@sgrekhov sgrekhov reopened this Oct 27, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 27, 2022
@sgrekhov @athomas
[co19] Roll co19 to 642b786a850a9de5ab75ce872c98d7d560fe9fc2
0973e6e 
2022-10-26 sgrekhov22@gmail.com dart-lang/co19#1399. Object member names are not allowed for positional fields names (dart-lang/co19#1513)
2022-10-25 sgrekhov22@gmail.com dart-lang/co19#1516.  [Records] Experimental flags added to legacy libraries (dart-lang/co19#1519)
2022-10-25 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.5.1 to 3.6.0 (dart-lang/co19#1517)
2022-10-24 sgrekhov22@gmail.com Fixes dart-lang/co19#1428. Subtyping. Unused variables removed from generated tests (dart-lang/co19#1514)
2022-10-24 sgrekhov22@gmail.com dart-lang/co19#1328. Excessive 'forgetType()' removed from arguments_binding_... tests (dart-lang/co19#1503)

Change-Id: I2f3b05ceaa4d0f899f5f107abd892fa73c76d62b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266040
Reviewed-by: Alexander Thomas <athom@google.com>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 27, 2022
@sgrekhov
dart-lang#1399. [Records] Tests for ambiguity with metadata annotatio…
8810d2c 
…ns added
eernstg pushed a commit that referenced this issue Oct 31, 2022
@sgrekhov
#1399. [Records] Check a big record with a large number of positional…
7cc8508 
… fields (#1518)

Authored by @sgrekhov.

Use a record with a large number of positional fields.
@sgrekhov sgrekhov closed this as completed Nov 2, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 7, 2022
@sgrekhov
dart-lang#1399. [Records] Metadata annotations tests improved
569f716
eernstg pushed a commit that referenced this issue Nov 7, 2022
@sgrekhov
#1399. [Records] Tests for ambiguity with metadata annotations added (#…
f5fa463 
…1524)

Authored by @sgrekhov.

Add tests for ambiguity with metadata annotations.
chloestefantsova pushed a commit that referenced this issue Nov 7, 2022
@sgrekhov
#1399. [Records] Check corner case with trailing zeros for positional…
4b2135b 
… field getter (#1515)
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 7, 2022
@sgrekhov @athomas
[co19] Roll co19 to 36cc25de009198a8516be7f12ac5b61069656d09
87cb9a6 
2022-11-03 sgrekhov22@gmail.com dart-lang/co19#1401. [Patterns] Logical-or tests added (dart-lang/co19#1520)
2022-11-02 sgrekhov22@gmail.com Fixes dart-lang/co19#1528. Update on clauses ambiguity tests (dart-lang/co19#1533)
2022-10-31 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] Check a big record with a large number of positional fields (dart-lang/co19#1518)

Change-Id: I7d87440512113230d5d8af2737684074e6906711
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267825
Reviewed-by: Alexander Thomas <athom@google.com>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 15, 2022
@sgrekhov @athomas
[co19] Roll co19 to 19439c0d58a0df422c4acc4ae97a3deeb98d0f67
5d677b4 
2022-11-08 sgrekhov22@gmail.com dart-lang/co19#1401. [Patterns] relational pattern tests added (dart-lang/co19#1535)
2022-11-08 sgrekhov22@gmail.com Fixes dart-lang/co19#1529. Fix record's fields name collision (dart-lang/co19#1532)
2022-11-07 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] Check corner case with trailing zeros for positional field getter (dart-lang/co19#1515)
2022-11-07 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] Tests for ambiguity with metadata annotations added (dart-lang/co19#1524)
2022-11-07 sgrekhov22@gmail.com dart-lang/co19#1401. [Patterns] logical-and pattern tests added (dart-lang/co19#1534)
2022-11-07 sgrekhov22@gmail.com Fixes dart-lang/co19#1530. Use correct record type (dart-lang/co19#1531)

Change-Id: I90052b87645f077959c433b823665355880b8cd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269302
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 2, 2022
@sgrekhov
dart-lang#1399. [Records] Allow legacy libraries that don't support r…
b0710f0 
…ecords to still be able to see the Record class in "dart:core"
eernstg pushed a commit that referenced this issue Feb 17, 2023
@sgrekhov
#1399. [Records] Allow legacy libraries that don't support records to…
f91e5d7 
… still be able to see the Record class in "dart:core" (#1571)
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Feb 21, 2023
@sgrekhov @athomas
[co19] Roll co19 to f91e5d74f9f0444495ca961fa5dafacac9a6922a
3424cc8 
2023-02-17 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] Allow legacy libraries that don't support records to still be able to see the Record class in "dart:core" (dart-lang/co19#1571)
2023-02-17 sgrekhov22@gmail.com dart-lang/co19#1860. Fix type_inference_A12_t01.dart. Don't expect warning (dart-lang/co19#1862)
2023-02-17 sgrekhov22@gmail.com Fixes dart-lang/co19#1860. Fix roll failures (dart-lang/co19#1861)
2023-02-16 sgrekhov22@gmail.com dart-lang/co19#1401. Calculating the static type of the pattern tests added (dart-lang/co19#1847)
2023-02-16 sgrekhov22@gmail.com dart-lang/co19#1401. Shared case scope test with labels and default case added (dart-lang/co19#1858)
2023-02-15 sgrekhov22@gmail.com Fixes dart-lang/co19#1837. Add additional unnecessary null-ckeck warnings (dart-lang/co19#1842)

Change-Id: I3a1f5deafd4f2868574f085495417ed37fe845b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284080
Reviewed-by: Alexander Thomas <athom@google.com>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jan 30, 2024
@sgrekhov
dart-lang#1399. Add more tests for records
f78c184
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jan 30, 2024
@sgrekhov
dart-lang#1399. Add more tests for records
fa81b26
eernstg pushed a commit that referenced this issue Jan 30, 2024
@sgrekhov
#1399. Add more tests for records (#2511)
4b3d2fd
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Feb 5, 2024
@sgrekhov
[co19] Roll co19 to d1ce99fc64d3766ec7dd82362cf80192262822ec
4cc0743 
2024-02-02 sgrekhov22@gmail.com Fix dart-lang/co19#2517. Fix wrong test, add experimental flags (dart-lang/co19#2518)
2024-02-02 sgrekhov22@gmail.com Fix dart-lang/co19#2490. Update incompatible with await tests according to the changed rule (dart-lang/co19#2516)
2024-02-01 sgrekhov22@gmail.com dart-lang/co19#2420. Add more exhaustiveness tests (dart-lang/co19#2513)
2024-01-31 sgrekhov22@gmail.com dart-lang/co19#2446. Add additional test for cast pattern (dart-lang/co19#2514)
2024-01-30 sgrekhov22@gmail.com dart-lang/co19#1399. Add more tests for records (dart-lang/co19#2511)
2024-01-30 sgrekhov22@gmail.com dart-lang/co19#2485. Update map and list constant literals tests. Add parenthesized for records (dart-lang/co19#2512)
2024-01-29 sgrekhov22@gmail.com Fixes dart-lang/co19#2490. Add more await tests for extension types (dart-lang/co19#2500)
2024-01-29 sgrekhov22@gmail.com dart-lang/co19#2119. Fix typo in Subtyping tests description (dart-lang/co19#2510)
2024-01-29 sgrekhov22@gmail.com Fixes dart-lang/co19#2505. Add more tests for `call` member (dart-lang/co19#2506)
2024-01-29 sgrekhov22@gmail.com dart-lang/co19#2420. Add cast-pattern tests for extension types (dart-lang/co19#2458)

Change-Id: I631705a013f9a77910ae0f0be5a9fea01e7c719f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350240
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: William Hesse <whesse@google.com>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 15, 2024
@sgrekhov
dart-lang#1399. Add more tests for records (dart-lang#2511)
c79ef8b
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Feb 15, 2024
@sgrekhov
dart-lang#1399. Add more tests for records (dart-lang#2511)
4d0b83e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eernstg eernstg

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sgrekhov @eernstg @itsjustkevin