Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ffi] CFE/analyzer error messages in different locations. #2004

Closed
dcharkes opened this issue Apr 5, 2023 · 0 comments
Closed

[ffi] CFE/analyzer error messages in different locations. #2004

dcharkes opened this issue Apr 5, 2023 · 0 comments
Assignees
@sgrekhov

Comments

@dcharkes
Copy link
Contributor

dcharkes commented Apr 5, 2023

Some of the diagnostics in Dart FFI get reported in different places for CFE vs analyzer. (On a field/class or on the annotation on that field or class.)

  • co19/LibTest/ffi/Array/Array.multi_A01_t02
  • co19/LibTest/ffi/Array/Array.multi_A02_t01
  • co19/LibTest/ffi/Array/Array.multi_A02_t02
  • co19/LibTest/ffi/Array/Array_A02_t01
  • co19/LibTest/ffi/Array/Array_A02_t02

Some tests rely on the fix in https://dart-review.googlesource.com/c/sdk/+/293600 which has landed today. (So you need the last build of the VM to get the error messages.)

From the triage in:
@sgrekhov sgrekhov self-assigned this Apr 6, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Apr 6, 2023
@sgrekhov
Fixes dart-lang#2004. Update expected errors locations for CFE
53b7758
@eernstg eernstg closed this as completed in 79b9b74 Apr 7, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Apr 14, 2023
@sgrekhov @athomas
[co19] Roll co19 to c01fbd751c060650b6582523a7751b83777026c3
b5ac282 
2023-04-11 sgrekhov22@gmail.com dart-lang/co19#1401. Exhaustiveness tests fixed and new ones added (dart-lang/co19#2019)
2023-04-11 sgrekhov22@gmail.com Fixes dart-lang/co19#2006. `Pointer` can have top types as type arguments (dart-lang/co19#2013)
2023-04-11 sgrekhov22@gmail.com Fixes dart-lang/co19#2010. Fix exhaustiveness tests for a cast-pattern (dart-lang/co19#2018)
2023-04-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2004. Update expected errors locations for CFE (dart-lang/co19#2011)
2023-04-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2005. DynamicLibrary.process() is supported on Windows (dart-lang/co19#2012)
2023-04-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2007. Fix UintPtr_A01_t01.dart not to fail on 32-bit platforms (dart-lang/co19#2014)
2023-04-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2008. Split pattern_context_A01_t01.dart test to multiple methods (dart-lang/co19#2015)
2023-04-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2009. Update scope_A01_t01.dart according to the current CFE behavior (dart-lang/co19#2016)

Change-Id: I5b43a5c5f133dded30564749b38f6a0c965b62fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295281
Reviewed-by: Alexander Thomas <athom@google.com>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 4, 2023
@sgrekhov
dart-lang#2004. Add deferred libraries tests according to the changed…
fd409c3 
… spec
eernstg pushed a commit that referenced this issue Dec 4, 2023
@sgrekhov
#2004. Add deferred libraries tests according to the changed spec (#2411
725d848 
)

Add deferred libraries tests according to the changed spec
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 11, 2023
@sgrekhov
[co19] Roll co19 to ea5e476b3af94f74f6996e4b4319bf03f9248c1c
8763ece 
2023-12-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2413. Add missing expected compile-time errors for CFE (dart-lang/co19#2418)
2023-12-07 sgrekhov22@gmail.com dart-lang/co19#2119. Run dart formatter on LibTest/async tests (dart-lang/co19#2417)
2023-12-06 sgrekhov22@gmail.com dart-lang/co19#2398. Make asyncStart/End() safe in LibTest/async (dart-lang/co19#2416)
2023-12-06 sgrekhov22@gmail.com Fixes dart-lang/co19#2355. Add more typed_date.setRange() tests (dart-lang/co19#2412)
2023-12-06 sgrekhov22@gmail.com dart-lang/co19#2404. Small code-style improvements and description update (dart-lang/co19#2414)
2023-12-04 sgrekhov22@gmail.com dart-lang/co19#2004. Add deferred libraries tests according to the changed spec (dart-lang/co19#2411)
2023-12-04 sgrekhov22@gmail.com Fixes dart-lang/co19#2383. Add more constant evaluation tests (dart-lang/co19#2396)

Change-Id: I15e0d681538fa0f2a311f74d1930fad7270b81a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340561
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcharkes @sgrekhov