Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some expected compile-time messages need to be updated after a CL lands #2413

Closed
chloestefantsova opened this issue Dec 5, 2023 · 0 comments
Closed

Some expected compile-time messages need to be updated after a CL lands #2413

chloestefantsova opened this issue Dec 5, 2023 · 0 comments
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@chloestefantsova
Copy link
Contributor

The CFE is bringing error reporting in cyclic typedef declarations closer to that of Analyzer. It is being done in the following CL: https://dart-review.googlesource.com/c/sdk/+/339941.

After the CL lands, the expectations of compile-time errors will need to be updated in the following tests.

  • co19/Language/Types/Type_Aliases/self_reference_t14
  • co19/Language/Types/Type_Aliases/self_reference_t15
  • co19/Language/Types/Type_Aliases/self_reference_t16
  • co19/Language/Types/Type_Aliases/self_reference_t17
  • co19/Language/Types/Type_Aliases/self_reference_t19
  • co19/Language/Types/Type_Aliases/self_reference_t20
@sgrekhov sgrekhov self-assigned this Dec 6, 2023
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Dec 6, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 7, 2023
@sgrekhov
Fixes dart-lang#2413. Add missing expected compile-time errors for CFE
0dc09c5
@eernstg eernstg closed this as completed in ea5e476 Dec 7, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 11, 2023
@sgrekhov
[co19] Roll co19 to ea5e476b3af94f74f6996e4b4319bf03f9248c1c
8763ece 
2023-12-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2413. Add missing expected compile-time errors for CFE (dart-lang/co19#2418)
2023-12-07 sgrekhov22@gmail.com dart-lang/co19#2119. Run dart formatter on LibTest/async tests (dart-lang/co19#2417)
2023-12-06 sgrekhov22@gmail.com dart-lang/co19#2398. Make asyncStart/End() safe in LibTest/async (dart-lang/co19#2416)
2023-12-06 sgrekhov22@gmail.com Fixes dart-lang/co19#2355. Add more typed_date.setRange() tests (dart-lang/co19#2412)
2023-12-06 sgrekhov22@gmail.com dart-lang/co19#2404. Small code-style improvements and description update (dart-lang/co19#2414)
2023-12-04 sgrekhov22@gmail.com dart-lang/co19#2004. Add deferred libraries tests according to the changed spec (dart-lang/co19#2411)
2023-12-04 sgrekhov22@gmail.com Fixes dart-lang/co19#2383. Add more constant evaluation tests (dart-lang/co19#2396)

Change-Id: I15e0d681538fa0f2a311f74d1930fad7270b81a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340561
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chloestefantsova @sgrekhov