Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of some errors due to changes with the constant evaluator. #2149

Closed
kallentu opened this issue Jul 25, 2023 · 0 comments
Closed

Removal of some errors due to changes with the constant evaluator. #2149

kallentu opened this issue Jul 25, 2023 · 0 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug

Comments

@kallentu
Copy link
Member

There are a few tests that need updating from changes in the const evaluator tidying up errors in https://dart-review.googlesource.com/c/sdk/+/312347

/=================================================================================================================================\
| co19/Language/Classes/Constructors/Generative_Constructors/execution_t09 broke (Pass -> MissingCompileTimeError, expected Pass) |
\=================================================================================================================================/

--- Command "dart2analyzer" (took 44ms):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dart out/ReleaseX64/gen/dartanalyzer.dart.snapshot -Dtest_runner.configuration=analyzer-asserts-linux --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.dart_tool/package_config.json --format=json /b/s/w/ir/cache/builder/sdk/tests/co19/src/Language/Classes/Constructors/Generative_Constructors/execution_t09.dart

static error failures:
- Missing expected unspecified error at line 34, column 3, length 5.

--- Re-run this test:
python3 tools/test.py -n analyzer-asserts-linux co19/Language/Classes/Constructors/Generative_Constructors/execution_t09


/============================================================================================================\
| co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t02 broke (Pass -> MissingCompileTimeError, expected Pass) |
\============================================================================================================/

--- Command "dart2analyzer" (took 51ms):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dart out/ReleaseX64/gen/dartanalyzer.dart.snapshot -Dtest_runner.configuration=analyzer-asserts-linux --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.dart_tool/package_config.json --format=json /b/s/w/ir/cache/builder/sdk/tests/co19/src/LanguageFeatures/Enhanced-Enum/grammar_A01_t02.dart

static error failures:
- Missing expected unspecified error at line 1, column 0.

--- Re-run this test:
python3 tools/test.py -n analyzer-asserts-linux co19/LanguageFeatures/Enhanced-Enum/grammar_A01_t02


/===================================================================================================================================\
| co19_2/Language/Classes/Constructors/Generative_Constructors/execution_t09 broke (Pass -> MissingCompileTimeError, expected Pass) |
\===================================================================================================================================/

--- Command "dart2analyzer" (took 42ms):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dart out/ReleaseX64/gen/dartanalyzer.dart.snapshot -Dtest_runner.configuration=analyzer-asserts-linux --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.dart_tool/package_config.json --format=json /b/s/w/ir/cache/builder/sdk/tests/co19_2/src/Language/Classes/Constructors/Generative_Constructors/execution_t09.dart

static error failures:
- Missing expected unspecified error at line 36, column 3, length 1.

--- Re-run this test:
python3 tools/test.py -n analyzer-asserts-linux co19_2/Language/Classes/Constructors/Generative_Constructors/execution_t09
@sgrekhov sgrekhov self-assigned this Jul 26, 2023
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Jul 26, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 26, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 26, 2023
eernstg pushed a commit that referenced this issue Jul 26, 2023
Note that grammar_A01_t02.dart intentionally contains a syntax error.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jul 30, 2023
2023-07-26 sgrekhov22@gmail.com dart-lang/co19#2149. [co19_2] Fix new errors due to changes with the constant evaluator (dart-lang/co19#2151)

Change-Id: I1e9796146595c22c2694c6e555127823fc7f07ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316582
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jul 31, 2023
2023-07-28 sgrekhov22@gmail.com dart-lang/co19#2142. Fix typo (dart-lang/co19#2155)
2023-07-26 sgrekhov22@gmail.com dart-lang/co19#2149. Fix new errors due to changes with the constant evaluator (dart-lang/co19#2152)
2023-07-26 sgrekhov22@gmail.com dart-lang/co19#2145. Add more tests for Variable (dart-lang/co19#2146)
2023-07-25 sgrekhov22@gmail.com dart-lang/co19#2142. Add syntax tests (dart-lang/co19#2148)

Change-Id: I6ee222b74fc092d93a1b76d35d89a008a97056be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316590
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants