#2145. Add more tests for Variable #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Jul 21, 2023
sgrekhov
commented
Jul 21, 2023
|
Found that we have no such tests at all! Created #2147 and deleted |
|
Friendly ping |
|
Ah, I'll take a look tomorrow. |
Add a `static late` case along with the `late static` case. The point is that `static late` _does_ exist in the grammar, but `late static` is always a syntax error, so we might have a bug where `static late` is accepted in this case because it is accepted in some cases, and that one is perhaps more likely than the bug where `late static` is accepted, anywhere.
eernstg
approved these changes
Jul 26, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 31, 2023
2023-07-28 sgrekhov22@gmail.com dart-lang/co19#2142. Fix typo (dart-lang/co19#2155) 2023-07-26 sgrekhov22@gmail.com dart-lang/co19#2149. Fix new errors due to changes with the constant evaluator (dart-lang/co19#2152) 2023-07-26 sgrekhov22@gmail.com dart-lang/co19#2145. Add more tests for Variable (dart-lang/co19#2146) 2023-07-25 sgrekhov22@gmail.com dart-lang/co19#2142. Add syntax tests (dart-lang/co19#2148) Change-Id: I6ee222b74fc092d93a1b76d35d89a008a97056be Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316590 Commit-Queue: William Hesse <whesse@google.com> Reviewed-by: William Hesse <whesse@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just the first part of the changes