Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two tests in LanguageFeatures/Private-fields-promotion expect to be able to type promote fields of a static value #2307

Closed
stereotype441 opened this issue Oct 12, 2023 · 0 comments
Assignees
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@stereotype441
Copy link
Member

The tests LanguageFeatures/Private-fields-promotion/promotion_A01_t07 and LanguageFeatures/Private-fields-promotion/promotion_A01_t08 both contain code that looks roughly like this:

enum E {
  e1, e2;

  final int? _x = 42;
}

main() {
  if (E.e1._x != null) {
    E.e1._x.isEven;
  }
}

For Dart 3.2, field promotion only considers an expression of the form target._fieldName to be stable (and thus promotable) if _fieldName represents a promotable field and target is one of the following:

  • this (includes implicit uses of this, so bare _fieldName is considered promotable inside an instance method of a class)
  • super
  • A local variable that isn't modified or write captured during the time period covered by the potential promotion.
  • An expression of the form target._fieldName that's considered stable.

We have considered expanding this list to include static constant fields such as E.e1 (dart-lang/language#3326), but we haven't done so; if we do decide to make this change, we won't make it until a future Dart release.

Accordingly, these two tests need to be updated so that they don't expect expressions like E.e1._x to undergo type promotion.

@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Oct 13, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 13, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 15, 2023
2023-10-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2310. Fix new roll failures (dart-lang/co19#2311)
2023-10-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2306. Fix promoted instance type in not_promotable_A01_t04.dart (dart-lang/co19#2309)
2023-10-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2307. Don't expect private fields promotion on static fields (dart-lang/co19#2308)
2023-10-11 sgrekhov22@gmail.com dart-lang/co19#2291. Update `Link.create()` tests according to the documentation (dart-lang/co19#2299)
2023-10-11 sgrekhov22@gmail.com dart-lang/co19#2275. Add `noSuchMethod` tests. Part 3 (dart-lang/co19#2294)
2023-10-10 sgrekhov22@gmail.com dart-lang/co19#2275. Add `noSuchMethod` tests. Part 4 (dynamic semantics) (dart-lang/co19#2296)
2023-10-10 sgrekhov22@gmail.com dart-lang/co19#2291. Update `Link.create()` according to the documentation. Part 2 (dart-lang/co19#2301)
2023-10-10 sgrekhov22@gmail.com Fixes dart-lang/co19#2268. Fix LibTest/io/WebSocket/closeCode_A01_t02.dart to be not racy (dart-lang/co19#2302)
2023-10-09 sgrekhov22@gmail.com dart-lang/co19#1400. Add more tests for private fields promotion of extension types (dart-lang/co19#2300)

Change-Id: Ib34f392c8a2a0aaab8b7b0cb028f918ab2a3249f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330460
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Development

No branches or pull requests

2 participants