Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileSystemEntity.type() called on a broken symlink should return notFound on all platforms #2329

Closed
brianquinlan opened this issue Oct 24, 2023 · 5 comments
Closed

FileSystemEntity.type() called on a broken symlink should return notFound on all platforms #2329

brianquinlan opened this issue Oct 24, 2023 · 5 comments
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@brianquinlan
Copy link
Contributor

A list of required changes is here: new_test_failures__logs_.txt

This is required to unbreak https://dart-review.googlesource.com/c/sdk/+/331841
@sgrekhov sgrekhov self-assigned this Oct 25, 2023
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Oct 25, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 25, 2023
@sgrekhov
Fixes dart-lang#2329. Fix FileSystemEntity.type() on Windows
7780a4c
@sgrekhov
Copy link
Contributor

@brianquinlan Fix is prepared here #2332. But I'm waiting for landing of https://dart-review.googlesource.com/c/sdk/+/331841 first. It's a common practice when we do a change and then update failing co19 tests

@eernstg
Copy link
Member

eernstg commented Oct 25, 2023

Oh, I just reviewed and landed #2332, I hope that doesn't create any problems.

@sgrekhov
Copy link
Contributor

Ok. I'll simply check the status of the https://dart-review.googlesource.com/c/sdk/+/331841 before doing the next roll. No problem, thank you!

@eernstg
Copy link
Member

eernstg commented Oct 25, 2023

Very good, thanks!

@brianquinlan
Copy link
Contributor Author

https://dart-review.googlesource.com/c/sdk/+/331841 is merged

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 27, 2023
@sgrekhov
[co19] Roll co19 to 3011a2e78f407ba3f9a3cf543fe17f5e8f2cc294
db3fddd 
2023-10-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2329. Fix FileSystemEntity.type() on Windows (dart-lang/co19#2332)
2023-10-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2330. Remove obsolete error expectation (dart-lang/co19#2331)
2023-10-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2317. Add tests for extension type type parameters in non-covariant position (dart-lang/co19#2318)
2023-10-25 sgrekhov22@gmail.com dart-lang/co19#2291. Update `Link.createSync()` according to the new documentation. Part 1 (dart-lang/co19#2305)
2023-10-24 sgrekhov22@gmail.com dart-lang/co19#2313. [Extension types] Add nullability tests (dart-lang/co19#2324)
2023-10-24 sgrekhov22@gmail.com dart-lang/co19#2323. Delete obsolete test (dart-lang/co19#2327)
2023-10-24 sgrekhov22@gmail.com Fixes dart-lang/co19#2323. Don't test datagram size more than 65503 (dart-lang/co19#2325)

Change-Id: I23b57a58b5cd6452e2beb923dd8cde6fd587f051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332206
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sgrekhov @brianquinlan @eernstg