Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LanguageFeatures/Extension-types/syntax_A04_t01 #2330

Closed
bwilkerson opened this issue Oct 24, 2023 · 0 comments
Closed

LanguageFeatures/Extension-types/syntax_A04_t01 #2330

bwilkerson opened this issue Oct 24, 2023 · 0 comments
Assignees
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@bwilkerson
Copy link
Member

The test expects an analyzer diagnostic on the line containing print(ET);. This diagnostic was previously being generated as a result of a bug that prevented the analyzer from seeing the declaration of the extension type. That bug been fixed by https://dart-review.googlesource.com/c/sdk/+/331749, so the second diagnostic is no longer being produced (and never ought to have been produced). Please remove the expectation.

@sgrekhov sgrekhov self-assigned this Oct 25, 2023
@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Oct 25, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 25, 2023
@sgrekhov sgrekhov reopened this Oct 25, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 27, 2023
2023-10-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2329. Fix FileSystemEntity.type() on Windows (dart-lang/co19#2332)
2023-10-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2330. Remove obsolete error expectation (dart-lang/co19#2331)
2023-10-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2317. Add tests for extension type type parameters in non-covariant position (dart-lang/co19#2318)
2023-10-25 sgrekhov22@gmail.com dart-lang/co19#2291. Update `Link.createSync()` according to the new documentation. Part 1 (dart-lang/co19#2305)
2023-10-24 sgrekhov22@gmail.com dart-lang/co19#2313. [Extension types] Add nullability tests (dart-lang/co19#2324)
2023-10-24 sgrekhov22@gmail.com dart-lang/co19#2323. Delete obsolete test (dart-lang/co19#2327)
2023-10-24 sgrekhov22@gmail.com Fixes dart-lang/co19#2323. Don't test datagram size more than 65503 (dart-lang/co19#2325)

Change-Id: I23b57a58b5cd6452e2beb923dd8cde6fd587f051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332206
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Development

No branches or pull requests

2 participants