Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing null aware elements #2694

Closed
eernstg opened this issue May 30, 2024 · 2 comments
Closed

Testing null aware elements #2694

eernstg opened this issue May 30, 2024 · 2 comments
Assignees

Comments

@eernstg
Copy link
Member

eernstg commented May 30, 2024

The null aware elements feature is being implemented, so we need some tests on that topic.

@sgrekhov sgrekhov self-assigned this May 30, 2024
@eernstg
Copy link
Member Author

eernstg commented May 30, 2024

Thanks!

sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jun 3, 2024
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jun 4, 2024
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jun 5, 2024
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jun 10, 2024
eernstg pushed a commit that referenced this issue Jun 12, 2024
Add the first bunch of null-aware elements tests. Note that 'syntax_A01_t01.dart' has intentional syntax errors.
eernstg pushed a commit that referenced this issue Jun 13, 2024
Add type inference tests for sets
eernstg pushed a commit that referenced this issue Jun 13, 2024
Add constants and runtime semantics tests
eernstg pushed a commit that referenced this issue Jun 13, 2024
Add test that unnecessary null-aware elements are reported
eernstg pushed a commit that referenced this issue Jun 13, 2024
Add more null-aware elements syntax tests. Note that LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_A04_t01.dart contains several intentional syntax errors.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jun 13, 2024
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jun 14, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jun 14, 2024
2024-06-13 sgrekhov22@gmail.com dart-lang/co19#2694. Add more checks for use of `?e` in an expression (dart-lang/co19#2713)
2024-06-13 sgrekhov22@gmail.com dart-lang/co19#2694. Add more null-aware elements syntax tests (dart-lang/co19#2706)
2024-06-13 sgrekhov22@gmail.com dart-lang/co19#2694. Add unnecessary null-aware elements tests (dart-lang/co19#2701)
2024-06-13 sgrekhov22@gmail.com dart-lang/co19#2694. Add constants and runtime semantics tests (dart-lang/co19#2700)
2024-06-13 sgrekhov22@gmail.com dart-lang/co19#2694. Add type inference tests for sets (dart-lang/co19#2697)
2024-06-12 sgrekhov22@gmail.com Fixes dart-lang/co19#2709. Remove outdated error expectation from redirecting_constructor_t03.dart (dart-lang/co19#2710)
2024-06-12 sgrekhov22@gmail.com Fixes dart-lang/co19#2707. Add more `call` member tests (dart-lang/co19#2708)
2024-06-12 sgrekhov22@gmail.com dart-lang/co19#2694. Add the first bunch of null-aware elements tests (dart-lang/co19#2696)

Change-Id: I026509d924976da91294d4d904f03a5d8027115b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371640
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
eernstg pushed a commit that referenced this issue Jun 17, 2024
Add more type inference tests
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jun 17, 2024
eernstg pushed a commit that referenced this issue Jun 18, 2024
Add syntax tests for different expressions
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jun 18, 2024
eernstg pushed a commit that referenced this issue Jun 19, 2024
Rename syntax tests for expressions
eernstg pushed a commit that referenced this issue Jun 20, 2024
Add syntax tests for different expressions. Part 3
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jun 21, 2024
2024-06-20 sgrekhov22@gmail.com dart-lang/co19#2694. Add syntax tests for different expressions. Part 4 (dart-lang/co19#2720)
2024-06-20 sgrekhov22@gmail.com dart-lang/co19#2694. Add syntax tests for different expressions. Part 3 (dart-lang/co19#2718)
2024-06-20 sgrekhov22@gmail.com dart-lang/co19#2694. Update warnings_* tests. Fix errors, add more cases (dart-lang/co19#2719)
2024-06-19 sgrekhov22@gmail.com dart-lang/co19#2694. Rename syntax tests for expressions (dart-lang/co19#2717)
2024-06-18 sgrekhov22@gmail.com dart-lang/co19#2694. Add syntax tests for different expressions. Part 2 (dart-lang/co19#2716)
2024-06-18 sgrekhov22@gmail.com dart-lang/co19#2694.Add syntax tests for different expressions. Part 1 (dart-lang/co19#2715)
2024-06-17 sgrekhov22@gmail.com dart-lang/co19#2694.Add more type inference tests (dart-lang/co19#2714)

Change-Id: I5c7dc8b775b23b1073ef3ff318ac5ededdb51c4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372621
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
@sgrekhov
Copy link
Contributor

Closing as completed. Expressions checklist below

Expression Test
?a.b = e https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_assignment_A02_t01.dart
?a?.b = e https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_assignment_A02_t01.dart
?a[e1] = e2 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_assignment_A02_t01.dart
?a?[e1] = e2 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_assignment_A02_t01.dart
?super.b = e https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_assignment_A02_t01.dart
?super[e1] = e2 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_assignment_A02_t01.dart
?this https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_this_super_A02_t01.dart
?super.b https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_this_super_A01_t01.dart
?super[e1] https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_this_super_A01_t01.dart
?super(42) https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_this_super_A01_t01.dart
?(e) https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_parenthesized_A01_t01.dart
?null https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/constants_A01_t01.dart
?1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t02.dart
?0x1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t02.dart
?true https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t02.dart
?false https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t02.dart
?'Hello' https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t02.dart
?r'Hello' https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t02.dart
?{1} https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t03.dart
?< int >{1} https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t03.dart
?{1: 2} https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t03.dart
?< int, int >{1: 2} https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t03.dart
?[1] https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t03.dart
?< int >[1] https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t03.dart
?const {1} https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t05.dart
?const < int >{1} https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t05.dart
?const {1: 2} https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t05.dart
?const < int, int >{1: 2} https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t05.dart
?const [1] https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t05.dart
?const [1] https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/warnings_A01_t05.dart
?(1, name: 2) https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_records_A01_t01.dart
?const (1, name: 2) https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_records_A01_t01.dart
?MyClass.new https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_functions_A01_t01.dart
?switch (1) { _ => 2 } https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_switch_A01_t01.dart
?throw 0 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_throw_A01_t01.dart
?() => 1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_functions_A01_t01.dart
?() async => 1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_functions_A01_t01.dart
?() {} https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_functions_A01_t01.dart
?() async {} https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_functions_A01_t01.dart
?new MyClass() https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_new_const_A01_t01.dart
?const MyClass() https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_new_const_A01_t01.dart
?a..toString() https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_cascade_A01_t01.dart
?a?..toString() https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_cascade_A01_t01.dart
?true ? 1 : 2 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_A05_t01.dart
?1 ?? 2 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_A05_t02.dart
?false || true https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_logical_A01_t01.dart
?true && false https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_logical_A01_t01.dart
?super == 1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_equality_A01_t01.dart
?1 is int https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_relational_A02_t01.dart
?1 as int https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_relational_A02_t02.dart
?1 < 2 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_relational_A01_t01.dart
?super < 2 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_relational_A01_t02.dart
?1 | 1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_bitwise_A01_t01.dart
?super | 1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_bitwise_A01_t02.dart
?1 ^ 1 syntax_bitwise_A01_t01.dart
?super ^ 1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_bitwise_A01_t02.dart
?1 & 1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_bitwise_A01_t01.dart
?super & 1 syntax_bitwise_A01_t02.dart
?1 << 1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_shift_A01_t01.dart
?super << 1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_shift_A01_t02.dart
?1 + 1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_additive_A01_t01.dart
?super + 1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_additive_A01_t02.dart
?1 * 1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_multiplicative_A01_t01.dart
?super * 1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_multiplicative_A01_t02.dart
?-1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_unary_prefix_A03_t01.dart
?!true https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_unary_prefix_A02_t01.dart
?~1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_unary_prefix_A03_t01.dart
?await 1 https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_unary_prefix_A04_t01.dart
?a++ https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_unary_postfix_A01_t01.dart
?a.b++ https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_unary_postfix_A01_t02.dart
?super.b++ https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_unary_postfix_A01_t02.dart
?(a, b) = (2, 3) https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_assignment_A03_t01.dart
?[a, b] = [2, 3] https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_assignment_A03_t02.dart
?{true: a, false: b} = {true: 2, false: 3} https://github.com/dart-lang/co19/tree/master/LanguageFeatures/Control-flow-collections/Null-aware-elements/syntax_assignment_A03_t02.dart

sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jun 26, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jun 28, 2024
2024-06-26 sgrekhov22@gmail.com dart-lang/co19#2694. Add experimental flag (dart-lang/co19#2725)
2024-06-21 sgrekhov22@gmail.com dart-lang/co19#2559. Add more tests for `augmented` expression in functions (dart-lang/co19#2711)
2024-06-21 sgrekhov22@gmail.com dart-lang/co19#2694. Add syntax tests for different expressions. Part 5 (dart-lang/co19#2721)

Change-Id: Ie201946b8e2a983bea393760192dc0af953f756f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373660
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants