Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Null-aware elements] co19 Tests #55928

Closed
Tracked by #55949
chloestefantsova opened this issue Jun 4, 2024 · 6 comments
Closed
Tracked by #55949

[Null-aware elements] co19 Tests #55928

chloestefantsova opened this issue Jun 4, 2024 · 6 comments
Assignees
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). feature-null-aware-elements Implementation of the Null-aware elements feature

Comments

@chloestefantsova
Copy link
Contributor

This is the tracking issue for co19 tests for the feature. Feature spec: https://github.com/dart-lang/language/blob/main/working/0323-null-aware-elements/feature-specification.md

@chloestefantsova chloestefantsova added area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). feature-null-aware-elements Implementation of the Null-aware elements feature labels Jun 4, 2024
@chloestefantsova
Copy link
Contributor Author

/cc @eernstg @sgrekhov

@sgrekhov
Copy link
Contributor

sgrekhov commented Jun 4, 2024

I don't know how the right approach should be but now we have two duplicated issues. There is co19 issue that I'm working on now dart-lang/co19#2694. May be it makes sense convert this issue into co19 issue and I'll close dart-lang/co19#2694 as a duplicate of this one?

@eernstg
Copy link
Member

eernstg commented Jun 12, 2024

It looks like there is a shared implementation issue that keeps track of all the implementation work associated with null-aware elements: #55949.

If nobody else refers to this issue, but various references to dart-lang/co19#2694 already exist then we should probably update that link such that it points to dart-lang/co19#2694, and then close this one.

(I've seen references to issues in non-sdk repos previously, so that should already be an accepted practice. For example, #47451.)

@chloestefantsova, would that cause any inconveniences for you?

@sgrekhov
Copy link
Contributor

As an option I can go on work on dart-lang/co19#2694 and when complete (hopefully it'll be soon) then close this issue as well

@eernstg
Copy link
Member

eernstg commented Jun 12, 2024

Sounds good, working on dart-lang/co19#2694 would then be the next step, no matter what. ;-)

@sgrekhov sgrekhov self-assigned this Jul 1, 2024
@sgrekhov
Copy link
Contributor

sgrekhov commented Jul 1, 2024

Closed as completed. See dart-lang/co19#2694

@sgrekhov sgrekhov closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). feature-null-aware-elements Implementation of the Null-aware elements feature
Projects
None yet
Development

No branches or pull requests

3 participants