Fixes #2304. Add more Object member tests
#2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Oct 16, 2023
LanguageFeatures/Extension-types/static_analysis_member_invocation_A01_t04.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A01_t03.dart
Show resolved
Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A01_t03.dart
Show resolved
Hide resolved
sgrekhov
commented
Oct 17, 2023
LanguageFeatures/Extension-types/static_analysis_member_invocation_A01_t03.dart
Show resolved
Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A01_t04.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Extension-types/static_analysis_member_invocation_A01_t03.dart
Show resolved
Hide resolved
eernstg
reviewed
Oct 17, 2023
| TypeET t2 = e2.runtimeType; | ||
|
|
||
| bool b1 = e1 == e1; | ||
| BoolET b2 = e2 == e2; |
LanguageFeatures/Extension-types/static_analysis_member_invocation_A01_t03.dart
Show resolved
Hide resolved
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 24, 2023
2023-10-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2319. Fix roll failures (dart-lang/co19#2321) 2023-10-23 sgrekhov22@gmail.com dart-lang/co19#1400. [Extension types] Add more top types tests (dart-lang/co19#2322) 2023-10-18 sgrekhov22@gmail.com dart-lang/co19#1400. [Extension types] Add more superinterfaces tests (dart-lang/co19#2315) 2023-10-18 sgrekhov22@gmail.com dart-lang/co19#2291. Add more Link.createSync() tests. Part 2 (dart-lang/co19#2316) 2023-10-17 sgrekhov22@gmail.com Fixes dart-lang/co19#2304. Add more `Object` member tests (dart-lang/co19#2312) 2023-10-17 sgrekhov22@gmail.com dart-lang/co19#2313. Fix expected static type in upper_bound_A01_t05.dart (dart-lang/co19#2314) Change-Id: Id5279b7bad5e45c7e8a5d2fa7cbffe49bd1b2093 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331860 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.