Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1400. [Extension types] Add more top types tests #2322

Merged
merged 6 commits into from
Oct 23, 2023
Merged

#1400. [Extension types] Add more top types tests #2322

merged 6 commits into from
Oct 23, 2023

Conversation

sgrekhov
Copy link
Contributor

No description provided.

eernstg
eernstg reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One case needs to be changed, though: It is an error for the representation type of an extension type declaration to be a bottom type.

LanguageFeatures/Extension-types/static_analysis_extension_types_A10_t14.dart Outdated Show resolved Hide resolved
LanguageFeatures/Extension-types/static_analysis_extension_types_A10_t14.dart Outdated Show resolved Hide resolved
LanguageFeatures/Extension-types/static_analysis_extension_types_A10_t15.dart Outdated Show resolved Hide resolved
@sgrekhov
Copy link
Contributor Author

Updated. Please take another look

@sgrekhov sgrekhov requested a review from eernstg October 23, 2023 10:17
@eernstg
Update static_analysis_extension_types_A10_t15.dart
0a82d60 
Change 'a' to 'the' in 'the type `void`'
eernstg
eernstg approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 3d79fab into dart-lang:master Oct 23, 2023
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 24, 2023
@sgrekhov @athomas
[co19] Roll co19 to 5d40729f9d7e6c97d7449a7647e1aab6e76f1818
5315b1d 
2023-10-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2319. Fix roll failures (dart-lang/co19#2321)
2023-10-23 sgrekhov22@gmail.com dart-lang/co19#1400. [Extension types] Add more top types tests (dart-lang/co19#2322)
2023-10-18 sgrekhov22@gmail.com dart-lang/co19#1400. [Extension types] Add more superinterfaces tests (dart-lang/co19#2315)
2023-10-18 sgrekhov22@gmail.com dart-lang/co19#2291. Add more Link.createSync() tests. Part 2 (dart-lang/co19#2316)
2023-10-17 sgrekhov22@gmail.com Fixes dart-lang/co19#2304. Add more `Object` member tests (dart-lang/co19#2312)
2023-10-17 sgrekhov22@gmail.com dart-lang/co19#2313. Fix expected static type in upper_bound_A01_t05.dart (dart-lang/co19#2314)

Change-Id: Id5279b7bad5e45c7e8a5d2fa7cbffe49bd1b2093
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331860
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
@sgrekhov sgrekhov deleted the co19-1400-new-9 branch January 10, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgrekhov @eernstg