Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2548. Add variance modifier declaration tests #2554

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of comments.

TypeSystem/type-variance/declaration_A01_t05.dart Outdated Show resolved Hide resolved
TypeSystem/type-variance/declaration_A01_t06.dart Outdated Show resolved Hide resolved
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the accidental test. Please take another look

TypeSystem/type-variance/declaration_A01_t05.dart Outdated Show resolved Hide resolved
TypeSystem/type-variance/declaration_A01_t06.dart Outdated Show resolved Hide resolved
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 7b84042 into dart-lang:master Feb 22, 2024
1 of 2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Mar 8, 2024
2024-03-05 sgrekhov22@gmail.com dart-lang/co19#2559. Add tests checking that `augment` is a built-in identifier (dart-lang/co19#2560)
2024-03-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 4.0.0 to 4.1.0 (dart-lang/co19#2557)
2024-02-23 sgrekhov22@gmail.com dart-lang/co19#2548. Add tests for out parameter in a contrvariant position (dart-lang/co19#2555)
2024-02-22 sgrekhov22@gmail.com dart-lang/co19#2548. Add variance modifier declaration tests (dart-lang/co19#2554)
2024-02-21 sgrekhov22@gmail.com dart-lang/co19#2548. Add `out` and `inout` to built-in identifiers tests (dart-lang/co19#2553)

Change-Id: Idd8ddf54f4cd7bb04b7296068653bee336d6d193
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356460
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants