#2548. Add tests for out parameter in a contrvariant position #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Feb 23, 2024
There was a problem hiding this comment.
Looks good!
One typo occurs in many places: 'contrvariant' should be 'contravariant'. Also, 'occurs in the contrvariant position' would probably be more reader-friendly if changed to 'occurs in a contravariant position' such that we don't imply that there is exactly one contravariant position in any given member signature, or, if there are several, that we've already agreed on which one it is.
|
Typo with article fixed. Please clarify where exactly " 'contrvariant' should be 'contravariant'"? I don't see such places |
|
Found it, sorry |
|
Fixed. Please take another look |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 8, 2024
2024-03-05 sgrekhov22@gmail.com dart-lang/co19#2559. Add tests checking that `augment` is a built-in identifier (dart-lang/co19#2560) 2024-03-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 4.0.0 to 4.1.0 (dart-lang/co19#2557) 2024-02-23 sgrekhov22@gmail.com dart-lang/co19#2548. Add tests for out parameter in a contrvariant position (dart-lang/co19#2555) 2024-02-22 sgrekhov22@gmail.com dart-lang/co19#2548. Add variance modifier declaration tests (dart-lang/co19#2554) 2024-02-21 sgrekhov22@gmail.com dart-lang/co19#2548. Add `out` and `inout` to built-in identifiers tests (dart-lang/co19#2553) Change-Id: Idd8ddf54f4cd7bb04b7296068653bee336d6d193 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356460 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before switching to macroses just want to submit the current work