Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2559. Mixin, enum and extension added to augmenting types tests #2612

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a couple of typos.

@sgrekhov sgrekhov requested a review from eernstg April 17, 2024 17:52
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet another typo, I think. ;-)

@sgrekhov sgrekhov requested a review from eernstg April 18, 2024 14:20
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again! ;-)

@eernstg eernstg merged commit 62fc300 into dart-lang:master Apr 18, 2024
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 19, 2024
2024-04-18 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting functions signature tests. Part 1 (dart-lang/co19#2613)
2024-04-18 sgrekhov22@gmail.com dart-lang/co19#2559. Mixin, enum and extension added to augmenting types tests (dart-lang/co19#2612)
2024-04-17 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting functions tests (dart-lang/co19#2611)

Change-Id: I19d7fe73c97c8a1cba47f8d953546bd68a9173a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363661
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants