-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2559. Mixin, enum and extension added to augmenting types tests #2612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, with a couple of typos.
LanguageFeatures/Augmentation-libraries/augmenting_types_A05_t03.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_types_A05_t04.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yet another typo, I think. ;-)
LanguageFeatures/Augmentation-libraries/augmenting_types_A05_t04_lib.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again! ;-)
2024-04-18 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting functions signature tests. Part 1 (dart-lang/co19#2613) 2024-04-18 sgrekhov22@gmail.com dart-lang/co19#2559. Mixin, enum and extension added to augmenting types tests (dart-lang/co19#2612) 2024-04-17 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting functions tests (dart-lang/co19#2611) Change-Id: I19d7fe73c97c8a1cba47f8d953546bd68a9173a7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363661 Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
No description provided.