Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2559. Add augmenting functions signature tests. Part 1 #2613

Merged
merged 3 commits into from
Apr 18, 2024
Merged

#2559. Add augmenting functions signature tests. Part 1 #2613

merged 3 commits into from
Apr 18, 2024

Conversation

sgrekhov
Copy link
Contributor

No description provided.

@sgrekhov sgrekhov marked this pull request as draft April 18, 2024 09:39
@sgrekhov sgrekhov marked this pull request as ready for review April 18, 2024 10:14
eernstg
eernstg reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I commented on a few declarations that seem to be duplicates of previous declarations for no clear reason.

LanguageFeatures/Augmentation-libraries/augmenting_functions_A04_t01_lib.dart Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_functions_A04_t01_lib.dart Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_functions_A04_t08_lib.dart Outdated Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_functions_A04_t08_lib.dart Outdated Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_functions_A04_t08_lib.dart Outdated Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_functions_A04_t08_lib.dart Outdated Show resolved Hide resolved
sgrekhov
sgrekhov commented Apr 18, 2024
View reviewed changes
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Duplicated declarations removed

LanguageFeatures/Augmentation-libraries/augmenting_functions_A04_t01_lib.dart Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_functions_A04_t01_lib.dart Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_functions_A04_t08_lib.dart Outdated Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_functions_A04_t08_lib.dart Outdated Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_functions_A04_t08_lib.dart Outdated Show resolved Hide resolved
LanguageFeatures/Augmentation-libraries/augmenting_functions_A04_t08_lib.dart Outdated Show resolved Hide resolved
@sgrekhov sgrekhov requested a review from eernstg April 18, 2024 16:38
@eernstg eernstg merged commit 140d5fa into dart-lang:master Apr 18, 2024
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 19, 2024
@sgrekhov
[co19] Roll co19 to 140d5faace9c44c95c58ca486389459d2d139b97
47e4c46 
2024-04-18 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting functions signature tests. Part 1 (dart-lang/co19#2613)
2024-04-18 sgrekhov22@gmail.com dart-lang/co19#2559. Mixin, enum and extension added to augmenting types tests (dart-lang/co19#2612)
2024-04-17 sgrekhov22@gmail.com dart-lang/co19#2559. Add more augmenting functions tests (dart-lang/co19#2611)

Change-Id: I19d7fe73c97c8a1cba47f8d953546bd68a9173a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363661
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgrekhov @eernstg