Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analyzer #108

Merged
merged 5 commits into from
May 2, 2017
Merged

Update analyzer #108

merged 5 commits into from
May 2, 2017

Conversation

danrubel
Copy link
Contributor

@danrubel danrubel commented May 2, 2017

This change updates the internals to use the newer analyzer API so that code_builder can be used with both analyzer 0.29.11 and 0.30.

@matanlurey
Copy link
Contributor

I'm OOO until Thursday so maybe Nate or Kevin or Andrew can help?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.661% when pulling 941afb1 on update-analyzer into a97998f on master.

@danrubel
Copy link
Contributor Author

danrubel commented May 2, 2017

Travis is unhappy because dartfmt passes on stable but fails for older 1.22.

@danrubel danrubel requested a review from kevmoo May 2, 2017 17:31
@kevmoo
Copy link
Member

kevmoo commented May 2, 2017

Looks like you need to dartfmt @danrubel

@alorenzen
Copy link
Contributor

Kevin, I think there may be a breaking change to dartfmt between versions. We can get either 1.22 or 1.23 passing, but not both.

@danrubel
Copy link
Contributor Author

danrubel commented May 2, 2017

@kevmoo

  • dartfmt was failing on stable for unrelated file (file that I did not change) test/e2e_test.dart
  • I formatted that file as part of this PR (see above)
  • Now dartfmt on stable is passing but failing on 1.22 (see comment above)

Not sure how to make two different versions of dartfmt happy about a file that I do not need to change.
How should I proceed?

@kevmoo
Copy link
Member

kevmoo commented May 2, 2017

We just need to ignore the lint for the other run

@danrubel
Copy link
Contributor Author

danrubel commented May 2, 2017

Is there a variable I can check in tool/presubmit.sh to only perform the dartfmt check on stable?

@kevmoo
Copy link
Member

kevmoo commented May 2, 2017

You can look at ENV

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.661% when pulling 3884f65 on update-analyzer into a97998f on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.661% when pulling c381d61 on update-analyzer into a97998f on master.

@danrubel
Copy link
Contributor Author

danrubel commented May 2, 2017

Presubmit updated. PTAL

@danrubel danrubel merged commit cf8e4bd into master May 2, 2017
@danrubel danrubel deleted the update-analyzer branch May 2, 2017 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants