Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function coverage considers abstract methods missed #398

Closed
liamappelbe opened this issue Jun 16, 2022 · 0 comments · Fixed by #412
Closed

Function coverage considers abstract methods missed #398

liamappelbe opened this issue Jun 16, 2022 · 0 comments · Fixed by #412
Assignees
@liamappelbe

Comments

@liamappelbe
Copy link
Contributor

Abstract methods should be ignored.
@liamappelbe liamappelbe self-assigned this Jun 16, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jun 23, 2022
@liamappelbe
[ VM / Service ] Add abstract flag to Function
921476e 
Bug: dart-lang/coverage#398
Change-Id: I1f6e16483e28fb7a77aebae079fd62abe9d16099
TEST=Added to get_object_rpc_test.dart
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249421
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jun 24, 2022
@emmanuel-p
Revert "[ VM / Service ] Add abstract flag to Function"
6c542ec 
This reverts commit 921476e.

Reason for revert: breaks google3 (b/236964692).

Original change's description:
> [ VM / Service ] Add abstract flag to Function
>
> Bug: dart-lang/coverage#398
> Change-Id: I1f6e16483e28fb7a77aebae079fd62abe9d16099
> TEST=Added to get_object_rpc_test.dart
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249421
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=bkonyi@google.com,liama@google.com

Change-Id: I1733080dadd6f283766dddbdbe1390d821f91f64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: dart-lang/coverage#398
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249680
Commit-Queue: Emmanuel Pellereau <emmanuelp@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Emmanuel Pellereau <emmanuelp@google.com>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jul 6, 2022
@liamappelbe
Reland "[ VM / Service ] Add abstract flag to Function"
aa2e198 
This reverts commit 6c542ec.

Switched vm_service from a minor version bump to a major one.
See: https://buganizer.corp.google.com/issues/236964692#comment4

Bug: dart-lang/coverage#398
Change-Id: I85f88d4a1cdcb878cbf77da283041458381e2a2b
TEST=Added to get_object_rpc_test.dart
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250772
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
@liamappelbe liamappelbe mentioned this issue Jul 6, 2022
Merged
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jul 7, 2022
@aam
Revert "Reland "[ VM / Service ] Add abstract flag to Function""
9b02bda 
This reverts commit aa2e198.

Reason for revert: broken g3 bot

Original change's description:
> Reland "[ VM / Service ] Add abstract flag to Function"
>
> This reverts commit 6c542ec.
>
> Switched vm_service from a minor version bump to a major one.
> See: https://buganizer.corp.google.com/issues/236964692#comment4
>
> Bug: dart-lang/coverage#398
> Change-Id: I85f88d4a1cdcb878cbf77da283041458381e2a2b
> TEST=Added to get_object_rpc_test.dart
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250772
> Commit-Queue: Liam Appelbe <liama@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>

TBR=bkonyi@google.com,asiva@google.com,liama@google.com

Change-Id: I6fbedfb146ee2157baf49162acd0c943402b6cbf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: dart-lang/coverage#398
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250787
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamappelbe liamappelbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore abstract methods dart-lang/coverage
1 participant
@liamappelbe