Ignore abstract methods #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 13, 2022
The required keyword means that adding a field to a class is a breaking change, and needs a major version bump instead of a minor one. All the fields are already nullable, and the constructors all use named parameters, so removing this keyword is a minor (non-breaking) change. Bug: dart-lang/coverage#412 Bug: https://buganizer.corp.google.com/issues/236964692 Change-Id: I410d0f4359c003696570dfb11e3e2f7f179fb9ee Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251443 Commit-Queue: Liam Appelbe <liama@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 15, 2022
This reverts commit 9b02bda. With https://dart-review.googlesource.com/c/sdk/+/251443 this is a non-breaking change. Bug: dart-lang/coverage#412 Change-Id: Iaa8a74ab8065380d2a7e8a8fc07fec3a4518d979 TEST=Added to get_object_rpc_test.dart Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251480 Commit-Queue: Ben Konyi <bkonyi@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com>
kevmoo
reviewed
Jul 20, 2022
|
Looks like we'll have to drop Dart 2.15? |
No, it's fine. Just need to make that test conditional. We already have a few tests that do different things on different versions. |
kevmoo
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #398