Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use VMScriptRef to identify VM scripts, not URI #216

Merged
merged 1 commit into from Oct 19, 2018
Merged

Use VMScriptRef to identify VM scripts, not URI #216

merged 1 commit into from Oct 19, 2018

Commits on Oct 19, 2018

  1. Use VMScriptRef to identify VM scripts, not URI 

    Previously, coverage collection assumed that a script could be uniquely
identified by URI, which is not a valid assumption. For example, when a
part is loaded via two libraries, both of which are loaded by an
isolate, the VM will track these are two scripts that map to the same
URI.

During collection, we now track each script by its (unique)
VMScriptRef. This ensures we lookup the correct script when computing
the affected line for each hit token. The hitmap remains URI based,
since in the end, we want a single, unified set of line->hitCount
mappings per script.

Fixes dart-lang#194
    @cbracken
    cbracken committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    2423f86 View commit details
    Browse the repository at this point in the history