This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
Copy collect_coverage's --scope-output flag to test_with_coverage.
#488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekxu16
approved these changes
May 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_with_coverage is a wrapper around collect_coverage and format_coverage that sets sensible defaults for all their flags that are designed to cover 99% of the coverage use cases. I have a couple of coverage collection scripts in dart-lang/native that only exist because they need to customize the value of the
--scope-outputflag that's passed to collect_coverage. Seems reasonable to just expose the flag in test_with_coverage.dart-lang/native#1120