Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace coverage.sh with a dart tool #1120

Closed
liamappelbe opened this issue May 5, 2024 · 1 comment · Fixed by #1124
Closed

Replace coverage.sh with a dart tool #1120

liamappelbe opened this issue May 5, 2024 · 1 comment · Fixed by #1124
Assignees
@liamappelbe
Labels
package:ffigen package:objective_c type-infra A repository infrastructure change or enhancement

Comments

@liamappelbe
Copy link
Contributor

Share code between the one in package:objective_c and the one in package:ffigen.

Also, dedupe the "Run VM tests" and "Collect coverage" steps. coverage.sh runs the tests for a second time, but due to a bug in that script they need to be run separately first, otherwise test failures are ignored.
@liamappelbe liamappelbe added type-infra A repository infrastructure change or enhancement package:ffigen package:objective_c labels May 5, 2024
@liamappelbe liamappelbe self-assigned this May 5, 2024
This was referenced May 5, 2024
Merged
Merged
@liamappelbe
Copy link
Contributor Author

liamappelbe commented May 6, 2024 •
edited

Actually, the only reason these scripts still exist is to customize the --scope-output flag. I can just add that flag to test_with_coverage, then delete these scripts: dart-lang/coverage#488

@liamappelbe liamappelbe mentioned this issue May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamappelbe liamappelbe

Labels
package:ffigen package:objective_c type-infra A repository infrastructure change or enhancement
Projects
ObjC/Swift interop
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete coverage.sh dart-lang/native
1 participant
@liamappelbe