Fix cast of nullable argument #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `as num` cast existed before the migration, but in the wrong place so the overall expression was still `dynamic`. Implicit casts from `dynamic` are still allowed, so it wasn't flagged that the cast was in the wrong place - disabling implicit casts from dynamic makes it more obvious that there is a problem, but doesn't fix the entire issue. In addition to the cast being in the wrong place, it also was to the wrong type. Casting to `num` instead of `num?` does not surface any warnings because it's valid to pass the `num` to an argument wanting `num?`. This was not surfaced originally due to a bug in the VM which causes the opt-in state of a package in the experiment allow list to _not_ control the soundness when executing. Add explicit opt in test runs for now. dart-lang/sdk#43243
jakemac53
approved these changes
Aug 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
as numcast existed before the migration, but in the wrong placeso the overall expression was still
dynamic. Implicit casts fromdynamicare still allowed, so it wasn't flagged that the cast was inthe wrong place - disabling implicit casts from dynamic makes it more
obvious that there is a problem, but doesn't fix the entire issue.
In addition to the cast being in the wrong place, it also was to the
wrong type. Casting to
numinstead ofnum?does not surface anywarnings because it's valid to pass the
numto an argument wantingnum?.This was not surfaced originally due to a bug in the VM which causes the
opt-in state of a package in the experiment allow list to not control
the soundness when executing. Add explicit opt in test runs for now.
dart-lang/sdk#43243