Skip to content

Commit

Permalink
Update SDK constraints for Dart 3.2.0 release (#2725)
Browse files Browse the repository at this point in the history
  • Loading branch information
parlough committed Nov 27, 2023
1 parent ec22fed commit 966c546
Show file tree
Hide file tree
Showing 9 changed files with 24 additions and 24 deletions.
32 changes: 16 additions & 16 deletions pkgs/dart_pad/lib/elements/dialog.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ enum DialogResult {

class Dialog {
final MDCDialog _mdcDialog;
final Element? _leftButton;
final Element? _rightButton;
final Element? _title;
final Element? _content;
final Element _leftButton;
final Element _rightButton;
final Element _title;
final Element _content;

Dialog()
: assert(querySelector('.mdc-dialog') != null),
Expand All @@ -30,10 +30,10 @@ class Dialog {
assert(querySelector('#my-dialog-title') != null),
assert(querySelector('#my-dialog-content') != null),
_mdcDialog = MDCDialog(querySelector('.mdc-dialog')!),
_leftButton = querySelector('#dialog-left-button'),
_rightButton = querySelector('#dialog-right-button'),
_title = querySelector('#my-dialog-title'),
_content = querySelector('#my-dialog-content');
_leftButton = querySelector('#dialog-left-button')!,
_rightButton = querySelector('#dialog-right-button')!,
_title = querySelector('#my-dialog-title')!,
_content = querySelector('#my-dialog-content')!;

Future<DialogResult> showYesNo(String title, String htmlMessage,
{String yesText = 'Yes', String noText = 'No'}) {
Expand Down Expand Up @@ -78,24 +78,24 @@ class Dialog {
DialogResult leftButtonResult,
DialogResult rightButtonResult,
[bool showLeftButton = true]) {
_title!.text = title;
_content!.setInnerHtml(htmlMessage, validator: PermissiveNodeValidator());
_rightButton!.text = rightButtonText;
_title.text = title;
_content.setInnerHtml(htmlMessage, validator: PermissiveNodeValidator());
_rightButton.text = rightButtonText;

final completer = Completer<DialogResult>();
StreamSubscription<MouseEvent>? leftSub;

if (showLeftButton) {
_leftButton!.text = leftButtonText;
_leftButton!.removeAttribute('hidden');
leftSub = _leftButton!.onClick.listen((_) {
_leftButton.text = leftButtonText;
_leftButton.removeAttribute('hidden');
leftSub = _leftButton.onClick.listen((_) {
completer.complete(leftButtonResult);
});
} else {
_leftButton!.setAttribute('hidden', 'true');
_leftButton.setAttribute('hidden', 'true');
}

final rightSub = _rightButton!.onClick.listen((_) {
final rightSub = _rightButton.onClick.listen((_) {
completer.complete(rightButtonResult);
});

Expand Down
2 changes: 1 addition & 1 deletion pkgs/dart_pad/pubspec.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkgs/dart_pad/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: The front end of DartPad.
publish_to: none

environment:
sdk: ^3.1.0
sdk: ^3.2.0

dependencies:
checked_yaml: ^2.0.3
Expand Down
2 changes: 1 addition & 1 deletion pkgs/dart_pad/third_party/pkg/split/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ homepage: https://github.com/flutter/devtools/tree/master/third_party/packages/s
version: 0.0.7

environment:
sdk: ^3.1.0
sdk: ^3.2.0

dependencies:
js: ^0.6.7
2 changes: 1 addition & 1 deletion pkgs/dart_services/pubspec.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkgs/dart_services/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: The backend service for DartPad.
publish_to: none

environment:
sdk: ^3.1.0
sdk: ^3.2.0

dependencies:
analysis_server_lib: ^0.2.4
Expand Down
2 changes: 1 addition & 1 deletion pkgs/dartpad_shared/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Shared code between the DartPad frontend and backend.
publish_to: 'none'

environment:
sdk: ^3.1.0
sdk: ^3.2.0

dependencies:
http: ^1.1.0
Expand Down
2 changes: 1 addition & 1 deletion pkgs/samples/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Sample code snippets for DartPad.
publish_to: 'none'

environment:
sdk: ^3.1.0
sdk: ^3.2.0

dependencies:
flutter:
Expand Down
2 changes: 1 addition & 1 deletion pkgs/sketch_pad/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: An experimental redux of the DartPad UI.
publish_to: 'none'

environment:
sdk: ^3.1.0
sdk: ^3.2.0

dependencies:
codemirror: any
Expand Down

0 comments on commit 966c546

Please sign in to comment.