Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dartz package #2362

Closed
brizaldi opened this issue Sep 19, 2022 · 10 comments · Fixed by dart-archive/dart-services#1004
Closed

Add support for dartz package #2362

brizaldi opened this issue Sep 19, 2022 · 10 comments · Fixed by dart-archive/dart-services#1004

Comments

@brizaldi
Copy link

https://pub.dev/packages/dartz

@brizaldi brizaldi changed the title Add support for dartz Add support for dartz package Sep 19, 2022
@johnpryan
Copy link
Contributor

Fixed by #995

@domesticmouse
Copy link
Member

Actually, this isn't shipped to production, so I'm re-opening this issue. This package has been shipped to our hidden testing instance https://dartpad.dev/?channel=dev

Please exercise your suggested package on this instance and confirm here that it works as intended. If you do confirm this as working I'll ship it to stable, beta, master, and old channels on dartpad.dev. If you don't confirm, I won't ship it.

@domesticmouse domesticmouse reopened this Jan 12, 2023
@brizaldi
Copy link
Author

@domesticmouse got this error when running the program with imported dartz package

Error compiling to JavaScript:
Info: Compiling with sound null safety
Error: Couldn't resolve the package 'dartz' in 'package:dartz/dartz.dart'.
lib/main.dart:1:8:
Error: Not found: 'package:dartz/dartz.dart'
import 'package:dartz/dartz.dart';
       ^
Error: Compilation failed.

@domesticmouse
Copy link
Member

Which DartPad channel are you using? If you are on stable, beta, master, or old you will see this error. I've only shipped the expanded package list to the hidden dev channel, referenced in my previous message.

Alternatively, you can supply some test code that exercises the package and I'll confirm it on the dev channel DartPad. Thanks!

@brizaldi
Copy link
Author

From the link above: https://dartpad.dev/?channel=dev

and here's the code:

import 'package:dartz/dartz.dart';

void main() {
  for (int i = 0; i < 5; i++) {
    print('hello ${i + 1}');
  }
}

@parlough
Copy link
Member

parlough commented Jan 13, 2023

Looks like it was only added to supported Flutter packages @domesticmouse, not Dart.

@domesticmouse
Copy link
Member

Looks like it was only added to supported Flutter packages @domesticmouse, not Dart.

Good catch, I'll roll up a fix up PR

@domesticmouse
Copy link
Member

PR: dart-archive/dart-services#996

@domesticmouse
Copy link
Member

The import works now =)

@brizaldi
Copy link
Author

Thanks @domesticmouse, can confirm that it's working perfectly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants