Added unread counter to console tab button. #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also removes the old "TestResultLabel" class, which should have been pulled in a previous PR. It's no longer used. |
domesticmouse
approved these changes
Apr 9, 2019
This was referenced Jan 12, 2023
Closed
Closed
johnpryan
pushed a commit
to johnpryan/dart-pad
that referenced
this pull request
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses one of Devon's later comments in #978 by adding a Primer.css "counter" to the console tab button. It's incremented when a new message or error is added to the console, and cleared/hidden when the user switches to that view. If they're already on it when a new message arrives, the counter is left in its hidden state.