-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update favicon to use new Dart logo #811
Comments
@chalin, do you happen to have a favicon already for the new logo? |
Hmm, I see the favicon contributed here: https://github.com/chalin/site-shared-dartlang/blob/00e7b236fe753fd7b93e73b58ed86bc1008afd0e/src/_assets/images/dart/favicon.ico is ~100kb. That seems pretty high; that'll effect initial page load for dart web sites. |
Let me know which resolutions you'd like in that .ico and I can create one for you. That one was created using:
You might not need that many sizes. |
(If there is a general agreement on which sizes are needed, I can change the main favicon.ico file too.) |
We should likely have a single one we can apply to all dart web properties. From some very casual browsing, we should be good with just 16x16 and 32x32. I don't know how efficient |
Sounds great! I'm happy to use whatever we end up using for dartlang.org. |
flutter.io uses a single 64x64 PNG. I'm inclined to do the same for darglang.org. Does that work for you? |
👍 |
Done: you can pick up assets from, e.g., https://github.com/dart-lang/site-www/pull/835/files. |
Thanks! |
cc @kwalrath @JekCharlsonYu
The text was updated successfully, but these errors were encountered: