Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update favicon to use new Dart logo #811

Closed
chalin opened this issue May 3, 2018 · 10 comments · Fixed by #812
Closed

Update favicon to use new Dart logo #811

chalin opened this issue May 3, 2018 · 10 comments · Fixed by #812

Comments

@chalin
Copy link

chalin commented May 3, 2018

cc @kwalrath @JekCharlsonYu

@devoncarew
Copy link
Member

@chalin, do you happen to have a favicon already for the new logo?

@devoncarew
Copy link
Member

Hmm, I see the favicon contributed here: https://github.com/chalin/site-shared-dartlang/blob/00e7b236fe753fd7b93e73b58ed86bc1008afd0e/src/_assets/images/dart/favicon.ico

is ~100kb. That seems pretty high; that'll effect initial page load for dart web sites.

@chalin
Copy link
Author

chalin commented May 3, 2018

Let me know which resolutions you'd like in that .ico and I can create one for you. That one was created using:

convert dart/logo/default.png -define icon:auto-resize=128,64,48,32,16 dart/favicon.ico

You might not need that many sizes.

@chalin
Copy link
Author

chalin commented May 3, 2018

(If there is a general agreement on which sizes are needed, I can change the main favicon.ico file too.)

@devoncarew
Copy link
Member

We should likely have a single one we can apply to all dart web properties. From some very casual browsing, we should be good with just 16x16 and 32x32.

I don't know how efficient convert is in terms of the size of the file it produces (I don't know that it isn't either, but we may want to check on it).

@devoncarew
Copy link
Member

If there is a general agreement on which sizes are needed, I can change the main favicon.ico file too

Sounds great! I'm happy to use whatever we end up using for dartlang.org.

@chalin
Copy link
Author

chalin commented May 3, 2018

flutter.io uses a single 64x64 PNG. I'm inclined to do the same for darglang.org. Does that work for you?

@devoncarew
Copy link
Member

👍

@chalin
Copy link
Author

chalin commented May 3, 2018

Done: you can pick up assets from, e.g., https://github.com/dart-lang/site-www/pull/835/files.

@devoncarew
Copy link
Member

Thanks!

johnpryan pushed a commit to johnpryan/dart-pad that referenced this issue Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants