Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the protos to use ctor named params #2619

Merged
merged 1 commit into from
Aug 15, 2023
Merged

update the protos to use ctor named params #2619

merged 1 commit into from
Aug 15, 2023

Conversation

devoncarew
Copy link
Member

  • update the protos to use ctor named params

This leverages the (restored) feature from package:protoc_plugin v21.1.0.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like (and missed) that!

@devoncarew
Copy link
Member Author

@johnpryan - gentle ping on the compilation artifact for the master channel.

@devoncarew devoncarew merged commit a344000 into main Aug 15, 2023
12 of 13 checks passed
@devoncarew devoncarew deleted the update_protos branch August 15, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants