-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-host the dart web UI on v3 of the server protocol #2691
Conversation
@johnpryan - no hurry on this; I'll likely have some questions about the workshops UI and testing mode code before landing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to keep the diagnostic messages and the test code features working for now. Is that something you can do in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated! What's a good way to test the codelabs locally?
You can test the codelabs and workshops by loading the right URL. For example: To test a workshop you can click on one of the links in the README and copy-paste the URL after the To test a codelab you can right-click and grab the |
You can also verify the embeds are working using the example at |
I can definitely add back in the test code features - I'd assumed from reading through the code that it wasn't used, but was mistaken. Do you think the diagnostic messages functionality is important? It's not currently exposed in the new UI, and I wasn't really planning to do it. I think it's useful for more sophisticated diagnostics in an IDE, but I don't think critical here. |
IIRC this was to enable corrections and documentation links: #1676 |
I restored the |
The protocol changed a bit in this PR (due to the inclusion context messages and changing how we stored location info on analysis issues); you'll need to run this against a local backend to see results. That's a good reminder though; we may want to land the dart-services + sketchpad portion of this PR first, and follow up ~an hour later with the part moving the current UI over to the new backend. |
Codelabs and the tests UI both seem to be working (responding to the server, showing analysis issues, supporting run, ...). |
We might want to update CONTRIBUTING.md and other readme files to remove any references to |
👍 ; I'd like to do that in a follow-up (this PR has accumulated a bunch of changes). I'll hold this PR until we determine the build issue with the master channel (we'll need that server to support the new protocol). |
The checks on the |
I think the checks were unintentionally all run against |
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.