Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc cleanup #2692

Merged
merged 1 commit into from
Oct 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,11 @@ cd dart-services
dart pub get
# Change the SDK version dart-services serves to the one you currently have installed
grind update-docker-version
# Begin serving the backend locally on port 8082.
# Begin serving the backend locally on port 8080.
FLUTTER_CHANNEL="stable" grind serve &

cd ../dart-pad
# Begin serving the front-end locally on port 8000, with the given backend on the default port 8082 this is defined in tools/grind.dart
# Begin serving the front-end locally on port 8000, with the given backend on the default port 8080 this is defined in tools/grind.dart
grind serve-local-backend
```

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ and Flutter. You can access it at [dartpad.dev](http://dartpad.dev).
| --- | --- | --- |
| [dart_pad](pkgs/dart_pad/) | The front end of DartPad. | [![dart_pad](https://github.com/dart-lang/dart-pad/actions/workflows/dart_pad.yml/badge.svg)](https://github.com/dart-lang/dart-pad/actions/workflows/dart_pad.yml) |
| [dart_services](pkgs/dart_services/) | The backend service for DartPad. | [![dart_services](https://github.com/dart-lang/dart-pad/actions/workflows/dart_services.yml/badge.svg)](https://github.com/dart-lang/dart-pad/actions/workflows/dart_services.yml) |
| [dartpad_shared](pkgs/dartpad_shared/) | Common code shared between the DartPad frontend and backend. | [![dartpad_shared](https://github.com/dart-lang/dart-pad/actions/workflows/dartpad_shared.yml/badge.svg)](https://github.com/dart-lang/dart-pad/actions/workflows/dartpad_shared.yml) |
| [dartpad_shared](pkgs/dartpad_shared/) | Shared code between the DartPad frontend and backend. | [![dartpad_shared](https://github.com/dart-lang/dart-pad/actions/workflows/dartpad_shared.yml/badge.svg)](https://github.com/dart-lang/dart-pad/actions/workflows/dartpad_shared.yml) |
| [samples](pkgs/samples/) | Sample code snippets for DartPad. | [![samples](https://github.com/dart-lang/dart-pad/actions/workflows/samples.yml/badge.svg)](https://github.com/dart-lang/dart-pad/actions/workflows/samples.yml) |
| [sketch_pad](pkgs/sketch_pad/) | An experimental redux of the DartPad UI. | [![sketch_pad](https://github.com/dart-lang/dart-pad/actions/workflows/sketch_pad.yml/badge.svg)](https://github.com/dart-lang/dart-pad/actions/workflows/sketch_pad.yml) |

Expand Down
2 changes: 1 addition & 1 deletion pkgs/dart_pad/tool/grind.dart
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Future<void> serveLocalAppEngine() async {
ConstTaskArgs('build', flags: {
_debugFlag: true,
}, options: {
_serverUrlOption: 'http://127.0.0.1:8082/',
_serverUrlOption: 'http://127.0.0.1:8080/',
}),
))
Future<void> serveLocalBackend() async {
Expand Down
4 changes: 2 additions & 2 deletions pkgs/dart_services/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ To run the server, run:
$ FLUTTER_CHANNEL="stable" dart tool/grind.dart serve
```

The server will run from port 8082 and export several JSON APIs, like
`/api/compile` and `/api/analyze`.
The server will run from port 8080 and export several JSON APIs, like
`/api/v3/compile` and `/api/v3/analyze`.

## Testing

Expand Down
2 changes: 1 addition & 1 deletion pkgs/dart_services/tool/grind.dart
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Future<void> serve() async {
'--channel',
_channel,
'--port',
'8082',
'8080',
]);
}

Expand Down
2 changes: 1 addition & 1 deletion pkgs/dartpad_shared/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: dartpad_shared
description: Common code shared between the DartPad frontend and backend.
description: Shared code between the DartPad frontend and backend.
publish_to: 'none'

environment:
Expand Down
2 changes: 1 addition & 1 deletion pkgs/sketch_pad/lib/utils.dart
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ bool hasFlutterWebMarker(String javaScript) {
return true;
}

// define('dartpad_main', ['dart_sdk', 'flutter_web']
// define('dartpad_main', ['dart_sdk', 'flutter_web']
if (javaScript.contains("define('") && javaScript.contains("'flutter_web'")) {
return true;
}
Expand Down
Loading